manage collection pages: needs a cancel button and missing lang string

Bug #1871722 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Cecilia Vela Gurovic

Bug Description

to replicate

- have a collection with one view
- go to manage the views in the collection (in pages and collections, click the bottom menu in the collection card)
- delete the view from the list so the collection has no more views in it
- click on "Next: Edit access"

result

- there is an error message displayed because you can't edit access on an empty collection, but there's no cancel button and the string in the message is broken

Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
milestone: none → 20.04rc1
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10873

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10873
Committed: https://git.mahara.org/mahara/mahara/commit/3d364fba18d48803c9beb5e29c54cd487a52e02d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3d364fba18d48803c9beb5e29c54cd487a52e02d
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Apr 9 10:12:21 2020 +1200

Bug 1871722: add cancel button to Collections manage views

to get the url for the cancel button I added back the code removed here
https://reviews.mahara.org/#/c/10633/12/htdocs/collection/views.php

behatnotneeded

Change-Id: I29e17a2dd5ffca4b69c9bb6c547af0ff3c848177

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
milestone: 20.04rc1 → 20.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10884

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10884
Committed: https://git.mahara.org/mahara/mahara/commit/3781ecf6a470c67be2579a43d37e4b625d3a416d
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 3781ecf6a470c67be2579a43d37e4b625d3a416d
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Apr 9 10:12:21 2020 +1200

Bug 1871722: add cancel button to Collections manage views

to get the url for the cancel button I added back the code removed here
https://reviews.mahara.org/#/c/10633/12/htdocs/collection/views.php

behatnotneeded

Change-Id: I29e17a2dd5ffca4b69c9bb6c547af0ff3c848177
(cherry picked from commit 3d364fba18d48803c9beb5e29c54cd487a52e02d)

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.