Update to upstream version 4.13.3-2

[dann frazier]

[Impact]
This release contains both bug-fixes, new hardware support, and new features for users of Mellanox network controllers. The notable ones are:

   * bug 1864475 - Add RoCE disable support

[Test Case]
The following development and SRU process will be followed:
https://wiki.ubuntu.com/mstflint-Updates

[Regression Potential]
In order to mitigate the regression potential, the aforementioned testing will be performed. The results of that testing, delineated in the following checklist, will be captured in this bug prior to adding the verification-done tag:

[E,B] Verified that all of the utilities from the current version in this series are still present in the new version.
[E,B] Verified that the supported flags for each utility in the new version, as described in --help output, are a superset of the existing version in this series.
[E,B] The existing version of mstflint upgrades cleanly to the new version.
[E,B] Mellanox has executed their mstflint test plan, and results are uploaded to this bug for each series.

[Łukasz Zemczak (sil2100)]

Ok, I guess this seems like a fine bug for this HWE backport - accepting. The eoan package has a small issue in the changelog, but it's not anything that warrants a reupload (the changelog entry says: "Backport to 18.04" for eoan).

[Łukasz Zemczak (sil2100)]

Hello dann, or anyone else affected,

Accepted mstflint into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mstflint/4.13.3+2-2~ubuntu19.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Hello dann, or anyone else affected,

Accepted mstflint into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mstflint/4.13.3+2-2~ubuntu18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[dann frazier (dannf)]

I used the attached script to compare the contents of the existing & proposed versions of this package in eoan and bionic. The output for each follows. The set of utilities in -proposed is a superset of the existing version in each release, so I'll check that off in the validation checklist. However, it is worth noting that in bionic we see that 2 files have been removed:

/usr/include/mstflint/mtcr_com_defs.h
/usr/include/mstflint/mtcr.h

While bionic's version shipped those headers, it did not ship a linkable version of the library. libmtcr_ul.a is statically linked into the commands that use it during build, so it is highly unlikely anyone depended on these headers. (The Debian maintainer caught this recently and explicitly stopped shipping the headers).

= eoan =
$ ./compare-file-list.sh mstflint_4.11.0+1-1_amd64.deb mstflint_4.13.3+2-2~ubuntu19.10.1_amd64.deb
= Files only in mstflint_4.11.0+1-1_amd64.deb =
= Files only in mstflint_4.13.3+2-2~ubuntu19.10.1_amd64.deb =
/usr/bin/mstfwtrace
/usr/bin/mstlink
/usr/bin/mstreg
/usr/bin/mstresourcedump
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mft_logger.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mlxpci/
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mlxpci/binary_file.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mlxpci/mlxpci_lib.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstfwreset/mlxfwresetlib/cmd_reg_mfrl.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstfwreset/mlxfwresetlib/cmd_reg_mpcir.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstfwtrace/
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstfwtrace/fw_trace_utilities.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstfwtrace/mstfwtrace.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstfwtrace/secure_fw_trace.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstresourcedump/
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstresourcedump/commands/
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstresourcedump/commands/CommandFactory.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstresourcedump/commands/DumpCommand.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstresourcedump/commands/__init__.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstresourcedump/commands/QueryCommand.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstresourcedump/commands/ResDumpCommand.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstresourcedump/fetchers/
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstresourcedump/fetchers/CapabilityFetcher.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstresourcedump/fetchers/__init__.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstresourcedump/fetchers/ResourceDumpFetcher.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstresourcedump/filters/
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstresourcedump/filters/__init__.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstresourcedump/filters/SegmentsFilter.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstresourcedump/__init__.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstresourcedump/mstresourcedump.py
/usr/lib/x86_64-linux-gnu/mstflint/python_tools/mstresourcedump/reso...

[dann frazier (dannf)]

= Clean upgrade verifications =
== eoan ==
ubuntu@mstflint-eoan:~$ sudo apt install mstflint -y
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following package was automatically installed and is no longer required:
  libfreetype6
Use 'sudo apt autoremove' to remove it.
The following additional packages will be installed:
  libibmad5 libibumad3 libmuparser2v5
The following NEW packages will be installed:
  libibmad5 libibumad3 libmuparser2v5 mstflint
0 upgraded, 4 newly installed, 0 to remove and 5 not upgraded.
Need to get 972 kB of archives.
After this operation, 6502 kB of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu eoan/universe amd64 libmuparser2v5 amd64 2.2.6.1+dfsg-1 [98.8 kB]
Get:2 http://archive.ubuntu.com/ubuntu eoan/main amd64 libibumad3 amd64 24.0-2 [25.4 kB]
Get:3 http://archive.ubuntu.com/ubuntu eoan/universe amd64 libibmad5 amd64 2.1.0-1build1 [32.5 kB]
Get:4 http://archive.ubuntu.com/ubuntu eoan/universe amd64 mstflint amd64 4.11.0+1-1 [815 kB]
Fetched 972 kB in 1s (1280 kB/s)
Selecting previously unselected package libmuparser2v5:amd64.
(Reading database ... 34499 files and directories currently installed.)
Preparing to unpack .../libmuparser2v5_2.2.6.1+dfsg-1_amd64.deb ...
Unpacking libmuparser2v5:amd64 (2.2.6.1+dfsg-1) ...
Selecting previously unselected package libibumad3:amd64.
Preparing to unpack .../libibumad3_24.0-2_amd64.deb ...
Unpacking libibumad3:amd64 (24.0-2) ...
Selecting previously unselected package libibmad5.
Preparing to unpack .../libibmad5_2.1.0-1build1_amd64.deb ...
Unpacking libibmad5 (2.1.0-1build1) ...
Selecting previously unselected package mstflint.
Preparing to unpack .../mstflint_4.11.0+1-1_amd64.deb ...
Unpacking mstflint (4.11.0+1-1) ...
Setting up libibumad3:amd64 (24.0-2) ...
Setting up libibmad5 (2.1.0-1build1) ...
Setting up libmuparser2v5:amd64 (2.2.6.1+dfsg-1) ...
Setting up mstflint (4.11.0+1-1) ...
Processing triggers for libc-bin (2.30-0ubuntu2.1) ...
Processing triggers for man-db (2.8.7-3) ...
ubuntu@mstflint-eoan:~$ dannf-enable-proposed.sh
Hit:1 http://security.ubuntu.com/ubuntu eoan-security InRelease
Hit:2 http://ppa.launchpad.net/dannf/dannf/ubuntu eoan InRelease
Hit:3 http://archive.ubuntu.com/ubuntu eoan InRelease
Hit:4 http://archive.ubuntu.com/ubuntu eoan-updates InRelease
Hit:5 http://archive.ubuntu.com/ubuntu eoan-backports InRelease
Get:6 http://archive.ubuntu.com/ubuntu eoan-proposed InRelease [107 kB]
Get:7 http://archive.ubuntu.com/ubuntu eoan-proposed/restricted Sources [3568 B]
Get:8 http://archive.ubuntu.com/ubuntu eoan-proposed/multiverse Sources [1340 B]
Get:9 http://archive.ubuntu.com/ubuntu eoan-proposed/main Sources [13.7 kB]
Get:10 http://archive.ubuntu.com/ubuntu eoan-proposed/universe Sources [6516 B]
Get:11 http://archive.ubuntu.com/ubuntu eoan-proposed/restricted amd64 Packages [12.5 kB]
Get:12 http://archive.ubuntu.com/ubuntu eoan-proposed/restricted Translation-en [4476 B]
Get:13 http://archive.ubuntu.com/ubuntu eoan-proposed/restricted amd64 c-n-f Metadata [332 B]
Get:14 http://archive.ubuntu.com/ubuntu eoan-proposed/main amd64 Packages [29.6 kB]
Get:15 http://archive.ub...

[dann frazier (dannf)]

= Command usage() regression checks =

Here's how I'm comparing the usage output of each command to make sure no flags were dropped/changed:

$ mkdir cur proposed
$ dpkg -L mstflint | grep ^/usr/bin/ > mstflint.commands
$ for cmd in $(< mstflint.commands); do $cmd -h > cur/$(basename $cmd).usage; done
### Upgrade mstflint to -proposed version
$ for cmd in $(< mstflint.commands); do $cmd -h > proposed/$(basename $cmd).usage; done
$ diff -urpN cur proposed

[dann frazier (dannf)]

= Command usage analysis =
Summary - the -proposed usage statements all describe a superset of the commands/arguments in the previous version, with one exception. In bionic, mstflint's -qq argument used to say it affected both the burn and query commands - but the -proposed version only claims to impact query. The upstream commit that made this change is a 17K line diff that just says "Porting MFT-4.9.0 changes":
  https://github.com/Mellanox/mstflint/commit/58bc68152b0f45200868299c03cadab1b985fdc7
I don't see anything in that commit that obviously changes when that parameter is used - I'll need to ask Mellanox to advise.

== eoan ==
=== mstconfig ===
Usage diff just adds a "DESCRIPTION" section, no OPTION changes.
=== mstflint ===
Supports all old arguments. Adds --latest_fw, --ir, --low-cpu and --flashed_version. Also adds image_reactivate and binary_compare subcommands.
=== mstmcra ===
Usage diff just adds a "DESCRIPTION" section, no OPTION changes.

== bionic ==
=== mstconfig ===
Usage diff just adds a "DESCRIPTION" section, no OPTION changes.
=== mstflint ===
Supports all old arguments. Adds --latest_fw, --ir, --low-cpu --flashed_version, --private_key2, --hmac_key & --key_uuid2.

** -qq used to say it impacted both burn and query commands, now just query. why? **

Also adds sign_with_hmac, image_reactivate and binary_compare commands.
=== mstmcra ===
No functional changes in --usage, just a new description & some cleanup.

=== mstmtserver ===
Adds a -v[ersion].

=== mstvpf ===
Adds a -r argument (doesn't say why)

[Jim Michelson (jpmichelson)]

The -qq flag was added to aid the Mellanox Global Support Organisation. In order for this -qq flag to have any effect a special external device is required. To use this device very specific knowledge is required.

If this device is not present the command will process normally.

I hope this addressed the question posed in comment #9.

regards,

jim

[dann frazier (dannf)]

Thanks Jim - given that, I've marked the command line portion of the testing complete.

[Eric Desrochers (slashd)]

Mellanox's verification report can be found in LP: #1864475.

- Eric

[Łukasz Zemczak (sil2100)]

Thank you for the very detailed testing. In case there would be more backports like these needed, I think such verification for an SRU exception would be satisfactory. As for the missing headers - I guess there is always some risk, but I agree that it is highly unlikely that we would have any consumers of that on bionic (I think we'd know that by now already). Let me proceed with releasing those.

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for mstflint has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package mstflint - 4.13.3+2-2~ubuntu18.04.1

---------------
mstflint (4.13.3+2-2~ubuntu18.04.1) bionic; urgency=medium

  * Backport to 18.04 (LP: #1869441):
    - Revert to debhelper-compat 11; no changes needed.
    - Adds mstreg command, which allows for disabling RoCE (LP: #1864475)

 -- dann frazier <email address hidden> Fri, 27 Mar 2020 16:18:02 -0600

[Launchpad Janitor (janitor)]

This bug was fixed in the package mstflint - 4.13.3+2-2~ubuntu19.10.1

---------------
mstflint (4.13.3+2-2~ubuntu19.10.1) eoan; urgency=medium

  * Backport to 18.04 (LP: #1869441):
    - Adds mstreg command, which allows for disabling RoCE (LP: #1864475)

 -- dann frazier <email address hidden> Fri, 27 Mar 2020 16:26:24 -0600