Image Gallery Blocks do not allow retractable option other than no

Bug #1868916 reported by Lisa Seeto
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Cecilia Vela Gurovic

Bug Description

When creating an image gallery block the option for "retractable" displays with the drop down list of three options: "no" (default), "yes", "automatically retract". Selecting anything other than "no" and trying to save the page causes the modal to stay open with no further information (error messages etc... displayed) You cannot save the block until you select "no". Closing the modal gives you the prompt to remove the block.

Investigation into whether it makes sense to be able to retract the Image Gallery at all and if the option is necessary is needed. If we don't need it, let's remove the option altogether.

Steps to reproduce:
Pre-requisites:
Have a site, with a user (any), and some image files uploaded.
1. Create a new page and create a new Image Gallery Block: On the configuration screen select the images (either from a folder if you have it or individually)
2. On the "Retractable" option select "Yes" or "Automatically retract"
3. Click save
Expected results:
The page is displayed with the newly created Image Gallery Block which is retractable.
Actual results:
The modal stays open and the page hangs with a loading spinner in the background and will not close until the block is deleted (cancelling or closing the modal)

Revision history for this message
Lisa Seeto (lisaseeto) wrote :
Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

I think this problem is related to a syntax error in javascript.
When I tried to replicate I can see this error in the js console on the browser:
SyntaxError: unexpected token: identifier

Changed in mahara:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
milestone: none → 20.04rc1
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10878

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10878
Committed: https://git.mahara.org/mahara/mahara/commit/6e76cc97f449929fe5715a714b92decae4001b8f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6e76cc97f449929fe5715a714b92decae4001b8f
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 15 10:43:15 2020 +1200

Bug 1868916: error syntax in blocks js

behatnotneeded

Change-Id: Id7c3169cbe1594c863e33b065fe6ea9cbad7e3f7

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10902

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10902
Committed: https://git.mahara.org/mahara/mahara/commit/7b832f9011d573c4c2fb45e43fe84469c35bab04
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 7b832f9011d573c4c2fb45e43fe84469c35bab04
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 15 10:43:15 2020 +1200

Bug 1868916: error syntax in blocks js

behatnotneeded

Change-Id: Id7c3169cbe1594c863e33b065fe6ea9cbad7e3f7
(cherry picked from commit 6e76cc97f449929fe5715a714b92decae4001b8f)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.04rc1 → 20.04.0
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.