Image Gallery Blocks do not allow retractable option other than no
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Cecilia Vela Gurovic |
Bug Description
When creating an image gallery block the option for "retractable" displays with the drop down list of three options: "no" (default), "yes", "automatically retract". Selecting anything other than "no" and trying to save the page causes the modal to stay open with no further information (error messages etc... displayed) You cannot save the block until you select "no". Closing the modal gives you the prompt to remove the block.
Investigation into whether it makes sense to be able to retract the Image Gallery at all and if the option is necessary is needed. If we don't need it, let's remove the option altogether.
Steps to reproduce:
Pre-requisites:
Have a site, with a user (any), and some image files uploaded.
1. Create a new page and create a new Image Gallery Block: On the configuration screen select the images (either from a folder if you have it or individually)
2. On the "Retractable" option select "Yes" or "Automatically retract"
3. Click save
Expected results:
The page is displayed with the newly created Image Gallery Block which is retractable.
Actual results:
The modal stays open and the page hangs with a loading spinner in the background and will not close until the block is deleted (cancelling or closing the modal)
Changed in mahara: | |
status: | New → In Progress |
importance: | Undecided → High |
assignee: | nobody → Cecilia Vela Gurovic (ceciliavg) |
milestone: | none → 20.04rc1 |
Changed in mahara: | |
milestone: | 20.04rc1 → 20.04.0 |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
I think this problem is related to a syntax error in javascript.
When I tried to replicate I can see this error in the js console on the browser:
SyntaxError: unexpected token: identifier