Design freeze prep for Mahara 20.04

Bug #1868613 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Evonne Cheung

Bug Description

Review of CSS etc. to prepare for the design freeze.

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.04.0 → 20.04rc1
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10841

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10841
Committed: https://git.mahara.org/mahara/mahara/commit/4b6089ca0e5ff63f7f1bca8f484baf546daccd88
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4b6089ca0e5ff63f7f1bca8f484baf546daccd88
Author: Evonne <email address hidden>
Date: Fri Apr 3 13:33:43 2020 +1300

Bug 1868613 Review of CSS etc. to prepare for the design freeze

Small bits of tidy up and alignment in raw.

behatnotneeded

Change-Id: Ia72cc25e42e768256d1f35283d5493565f89ff52

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.04rc1 → 20.04.0
status: Confirmed → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10855

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10855
Committed: https://git.mahara.org/mahara/mahara/commit/a747728cb9df822f295c694bdff8929975c6d847
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a747728cb9df822f295c694bdff8929975c6d847
Author: Evonne <email address hidden>
Date: Mon Apr 6 15:20:07 2020 +1200

Bug 1868613 Class names renamed

icon-large is no more, changed to icon-lg.

behatnotneeded

Change-Id: Iaafc6a8545d943621a807ac823c1e87efce29125

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10856

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10856
Committed: https://git.mahara.org/mahara/mahara/commit/09410b973bfbc4eb72cb1013565eabdf004f6306
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 09410b973bfbc4eb72cb1013565eabdf004f6306
Author: Evonne <email address hidden>
Date: Mon Apr 6 15:20:07 2020 +1200

Bug 1868613 Class names renamed

icon-large is no more, changed to icon-lg.

behatnotneeded

Change-Id: Iaafc6a8545d943621a807ac823c1e87efce29125
(cherry picked from commit a747728cb9df822f295c694bdff8929975c6d847)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10865

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10865
Committed: https://git.mahara.org/mahara/mahara/commit/cfa73c446bf33fd8f22a2e20518a7c1e1c16d1f6
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit cfa73c446bf33fd8f22a2e20518a7c1e1c16d1f6
Author: Evonne <email address hidden>
Date: Wed Apr 8 08:26:54 2020 +1200

Bug 1868613 Dashboard missing some classes for consistencies

Added class widget and home-info-box into the markup to target
the right divs.

behatnotneeded

Change-Id: I80a91bfb308c8646a0ea5d6ab29ac7f2b4ea2680

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10868

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10868
Committed: https://git.mahara.org/mahara/mahara/commit/f540e11abec917d1e2be69baf09aa595e4e910d8
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit f540e11abec917d1e2be69baf09aa595e4e910d8
Author: Evonne <email address hidden>
Date: Wed Apr 8 08:26:54 2020 +1200

Bug 1868613 Dashboard missing some classes for consistencies

Added class widget and home-info-box into the markup to target
the right divs.

behatnotneeded

Change-Id: I80a91bfb308c8646a0ea5d6ab29ac7f2b4ea2680
(cherry picked from commit cfa73c446bf33fd8f22a2e20518a7c1e1c16d1f6)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10876

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10877

Changed in mahara:
status: Fix Committed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10877
Committed: https://git.mahara.org/mahara/mahara/commit/df436935143511d314869f379cc0f5d057582963
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit df436935143511d314869f379cc0f5d057582963
Author: Evonne <email address hidden>
Date: Wed Apr 15 09:29:56 2020 +1200

Bug 1868613 Matrix table tooltips pushes page below footer

Removed visibility: hidden and put in display: none !important for
the popover, so that it doesn't leave 'fake' space on the page.

behatnotneeded

Change-Id: Ie393861fbf57dd2be7abe86936540a7ed86bac5c

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10887

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10887
Committed: https://git.mahara.org/mahara/mahara/commit/84e56cdd6e0927f4481c6d75bcd7c1c719969366
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 84e56cdd6e0927f4481c6d75bcd7c1c719969366
Author: Evonne <email address hidden>
Date: Wed Apr 15 09:29:56 2020 +1200

Bug 1868613 Matrix table tooltips pushes page below footer

Removed visibility: hidden and put in display: none !important for
the popover, so that it doesn't leave 'fake' space on the page.

behatnotneeded

Change-Id: Ie393861fbf57dd2be7abe86936540a7ed86bac5c
(cherry picked from commit df436935143511d314869f379cc0f5d057582963)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10890

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.04.0 → 20.04rc1
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10876
Committed: https://git.mahara.org/mahara/mahara/commit/5efffce04ab3b1842b8711b8ddfd240196265a23
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5efffce04ab3b1842b8711b8ddfd240196265a23
Author: Evonne <email address hidden>
Date: Tue Apr 14 15:53:27 2020 +1200

Bug 1868613 Hover states for buttons missing variables

Put in variables for hover/focus states for buttons.

behatnotneeded

Change-Id: I5de9acfaa799aeb3cca5a72d02cd978db2fd7bd3

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10904

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10904
Committed: https://git.mahara.org/mahara/mahara/commit/9ad1862255df9661b840d3997b4216e56799bd93
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 9ad1862255df9661b840d3997b4216e56799bd93
Author: Evonne <email address hidden>
Date: Tue Apr 14 15:53:27 2020 +1200

Bug 1868613 Hover states for buttons missing variables

Put in variables for hover/focus states for buttons.

behatnotneeded

Change-Id: I5de9acfaa799aeb3cca5a72d02cd978db2fd7bd3
(cherry picked from commit 5efffce04ab3b1842b8711b8ddfd240196265a23)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10905

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10890
Committed: https://git.mahara.org/mahara/mahara/commit/c521ffdf8160e1de4830e2c9132ed3cb99eec821
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c521ffdf8160e1de4830e2c9132ed3cb99eec821
Author: Evonne <email address hidden>
Date: Thu Apr 16 11:19:49 2020 +1200

Bug 1868613 body font size inheriting from somewhere else

Body was inheriting styles that wasn't intended for it, removed it
so increasing base font size variable can work.

There was a bunch of things relating to adding a block via commit
18bab0286e92a72f92b7e270d3d96646a9ebe320

The other bits were removed by commit
6cee4292a93deaeb049c856f7fb2b261eb76fe79
when we changed how we add a block to a page

But one sass/css bit was left so will remove now

behatnotneeded

Change-Id: I65698e42493807eb5d044f3b9ac094e180d44ea9

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10914

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10914
Committed: https://git.mahara.org/mahara/mahara/commit/b2ca126c02a9a11632aeb7549bd9e3d817558636
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit b2ca126c02a9a11632aeb7549bd9e3d817558636
Author: Evonne <email address hidden>
Date: Thu Apr 16 11:19:49 2020 +1200

Bug 1868613 body font size inheriting from somewhere else

Body was inheriting styles that wasn't intended for it, removed it
so increasing base font size variable can work.

There was a bunch of things relating to adding a block via commit
18bab0286e92a72f92b7e270d3d96646a9ebe320

The other bits were removed by commit
6cee4292a93deaeb049c856f7fb2b261eb76fe79
when we changed how we add a block to a page

But one sass/css bit was left so will remove now

behatnotneeded

Change-Id: I65698e42493807eb5d044f3b9ac094e180d44ea9
(cherry picked from commit c521ffdf8160e1de4830e2c9132ed3cb99eec821)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10905
Committed: https://git.mahara.org/mahara/mahara/commit/ceee2dbe769604202b2511b98d149e25984b0597
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ceee2dbe769604202b2511b98d149e25984b0597
Author: Evonne <email address hidden>
Date: Fri Apr 17 15:54:23 2020 +1200

Bug 1868613 Font size base not allowing child themes to override

$font-size-base was missing a !default after the variable, so
changing the variable in child themes wasn't overriding it.

behatnotneeded

Change-Id: I66a524bc2f4c9a03a732b6f62d1072a02fd14775

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
milestone: 20.04rc1 → 20.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10921

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10921
Committed: https://git.mahara.org/mahara/mahara/commit/7169719447532c39d1b1789a98ebf8f23b125e87
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 7169719447532c39d1b1789a98ebf8f23b125e87
Author: Evonne <email address hidden>
Date: Fri Apr 17 15:54:23 2020 +1200

Bug 1868613 Font size base not allowing child themes to override

$font-size-base was missing a !default after the variable, so
changing the variable in child themes wasn't overriding it.

behatnotneeded

Change-Id: I66a524bc2f4c9a03a732b6f62d1072a02fd14775
(cherry picked from commit ceee2dbe769604202b2511b98d149e25984b0597)

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.