drag events not being propagated to home applets correctly

[Bill Filler]

Binary package hint: hildon-desktop

Drag events are not being propagated to the home applet correctly and require a click, hold for ~1second then drag before being propagated. This negatively affects home applets that need the drag events immediately. The delay is controlled by the CLICK_TIMEOUT define in libhildondesktop/hildon-desktop-home-item.c.

I've committed a fix, Revision 317, 318, 332 in Launchpad at: https://code.launchpad.net/~ubuntu-mobile/hildon-desktop/ubuntu

The fix involves setting the CLICK_TIMEOUT to 0 seconds based on the value of a new gconf setting.

[yanglei (lei-a-yang)]

Change owner to Horace.

Somehow I cannot change importance.

[Bill Filler (bfiller)]

Changing owner back to me as I have fixed already and am working on it in Ubuntu

[Daniel Holbach (dholbach)]

Changing to ubuntu-main-sponsors as hildon-desktop is in main.

[Bill Filler (bfiller)]

I've attached the patch for this fix. This has been committed into Launchpad. Upload of hildon-desktop_2.0.9-1ubuntu1 into main will contain the fix. The package has been temporarily uploaded to PPA at http://ppa.launchpad.net/ubuntu-mobile/ubuntu until the fix gets into main.

[Launchpad Janitor (janitor)]

This bug was fixed in the package hildon-desktop - 1:2.0.9-1ubuntu1

---------------
hildon-desktop (1:2.0.9-1ubuntu1) hardy; urgency=low

  * Rebased to upstream version 1:2.0.9-1 from 1:0.0.43-1 from bzr
    734..803
  * added cdbs simple-patchsys support and appropriate build dependency
  * removed ubuntu and moblin changes from source, added as patch files:
  * 01_ume_layout_configuration.patch:
    modifications made to hildon layout configuration files for UME.
    It includes replacing the Top and Bottom panels with the new
    Marquee panel.
  * 02_build_mods.patch:
    adds ume specific build changes to makefile, configure and autoconf
  * 03_gconf_related.patch:
    adds gconf schema and key defines for newly created gconf keys
    that are used by other patches to conditionalize certain behavior
    at runtime based on gconf values.
  * 04_container_visibility.patch:
    adds support to configure desktop-panels defined in desktop.conf
    with newly created X-Hide-On-Home setting which controls if the
    panel is hidden or shown when the home window is shown.
    fixes LP: #186875
  * 05_hide_banner.patch:
    adds gconf support to enable/disable showing built-in hildon banner
    for app launching. Default to disable for UME, as UME home plugin
    displays it's own banner for app launching.
  * 06_type_changes_for_64bit.patch:
    changes to support building on 64 bit platforms.
  * 07_home_window_menu_visibility.patch:
    adds gconf support to enable/disable showing of home window menu.
    Default to disable for UME as home window menu is not used.
    fixes LP: #186859
  * 08_home_window_titlebar_visibility.patch:
    adds gconf support to enable/disable showing of home applet titlebar.
    Default to disable for UME as home applet titlebar is not necessary.
    fixes LP: #186857
  * 09_home_applet_resize_fix.patch:
    fixes to prevent home applet from being incorrectly resized.
    fixes LP: #186868
  * 10_drag_event_fix.patch:
    adds gconf support to allow propagation of drag events to home applet
    without having to click and hold for a certain period. LP: #186843
  * 11_window_filter.patch:
    moblin.org patch to allow non-hildon windows to be managed by
    window manager.
  * 12_statusbar_plugin_paint_fix.patch:
    moblin.org patch to fix repaint issues with non-hildon statusbar
    plugins.
  * 13_active_window_notification.patch:
    moblin.org patch to emit new signal "active-window-update" when
    hd_wm_application_set_active_window is called. Used by marquee panel.
  * 14_display_handle_return.patch:
    moblin.org patch to add function hd_wm_window_get_display() to return
    X Display struct.
  * 15_libstartup_notification_crash_fix.patch:
    moblin.org fix for crash on libstartup notification
  * 16_loopback_window_list.patch:
    moblin.org patch to libhildonwm/hd-wm.c hd_wm_switch_info_window()
    function to return first window in list if last window reached.
    Used by marquee panel.
  * 17_statusbar_container.patch:
    moblin.org patch to support new marquee panel with embedded statusbar
    container.
  * 18_mix_build.patch:
    moblin.org patch to use gint instead of guint in certain places.
...

[Bob Spencer (bob-spencer)]

Added bfillers patch below (thanks Bill). This update is not so important as the Hildon 2.0 code in Hardy is the one that should be maintained and has already been fixed awhile.

[yanglei (lei-a-yang)]

Bill and Bob,

Can you help to describe more detailed steps to help us verify the bug fix?

I did not understand how to detect the drag event, click and drag icons on desktop or blank area?
how to adjust if the event is propagated?

Thanks,
Lei Y

[yanglei (lei-a-yang)]

this bug has been Fixed more than 1 month.
But here is no clear steps to reproduce and verify, and we did not see the similar symptoms when recent tests, QA close the bug without verification.

Bill or anyone, if you find it is not fixed yet, please help re-open the bug.
Thanks.

[yanglei (lei-a-yang)]

this bug has been Fixed more than 1 month in moblin-ui-framework project.
But here is no clear steps to reproduce and verify, and we did not see the similar symptoms when recent tests, QA close the bug without verification.

Bill or anyone, if you find it is not fixed yet, please help re-open the bug.
Thanks.

[Bob Spencer (bob-spencer)]

yanglei wrote:
> this bug has been Fixed more than 1 month in moblin-ui-framework
> project.
> But here is no clear steps to reproduce and verify, and we did not
> see the similar symptoms when recent tests, QA close the bug without
> verification.
>
> Bill or anyone, if you find it is not fixed yet, please help re-open
> the bug.
> Thanks.
>
> ** Changed in: moblin-ui-framework
> Status: Fix Committed => Fix Released

This was fixed in the Hardy code base with the newest Hildon and
patches.