[SRU] Connections to Neutron are not closed properly in v0.26.0

[Corey Bryant]

[Impact]
<LarsErikP> Lars Erik Pedersen in #ubuntu-server reports the following issue:

The problem we're having is with octavia-dashboard. If you leave a browser at the load-balancer page, apache starts to accumulate threads, and will eventually run out of memory. I recently tested by installin openstack 0.27.0 with pip, and that fixed the issue

He has tested with 0.27.0 installed from pip and it fixes the issue for him.

The related fix we believe is https://github.com/openstack/openstacksdk/commit/41740827c4702e8fcaebdf6adf7a2d49a557ec14

They do seem to be related, though s/pids/threads.

For more details on the original bug see: https://storyboard.openstack.org/#!/story/2005306

[Test Case]
Deploy openstack stein with octavia + octavia-dashboard. Leave a browser at the load-balancer page, apache starts to accumulate threads, and will eventually run out of memory. Lars has volunteered to test this once it is in proposed.

Additional deployment/tempest regression testing will also be required by the openstack team.

[Regression Potential]
This fix has already landed in the stable/stein branch upstream, helping to mitigate regression potential.

The version bump for stable/stein has been reviewed at: https://review.opendev.org/#/c/649154/

The change does make an API change, as can be seen here (note the differences between Proxy and OpenStackSDKAdapter):
https://docs.openstack.org/openstacksdk/rocky/contributor/layout.html#proxy
https://docs.openstack.org/openstacksdk/stein/contributor/layout.html#proxy

The change requires a minimum of keystoneauth1==3.13.0, and we already have 3.13.1 in the stein cloud archive.

[Discussion]
Plan is to bump python-openstacksdk from 0.26.0 to 0.27.0 for stein inline with upstream. This is not the typical process we follow, but in this case there is an API change and the only patch in the new minor release that affects package behavior is the the patch for this fix (the 3 other patches are to .zuul.yaml, .gitreview, and tox.ini).

[Corey Bryant (corey.bryant)]

Hello Corey, or anyone else affected,

Accepted python-openstacksdk into stein-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:stein-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-stein-needed to verification-stein-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-stein-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Lars Erik Pedersen (pedersen-larserik)]

I still dont see the new version in stein-proposed.. Did something fail in the deployment?

[Corey Bryant (corey.bryant)]

@Lars, it should be fixed and in stein-proposed now.

[Lars Erik Pedersen (pedersen-larserik)]

@Corey yeah! I'll test asap!

[Lars Erik Pedersen (pedersen-larserik)]

Tested in bionic according to the testcase with:
* python3-openstacksdk 0.27.0-0ubuntu1~cloud0
* openstack-dashboard 3:15.1.1-0ubuntu1.1~cloud1
* python3-octavia-dashboard 3.0.0-0ubuntu1~cloud0

It fixes the bug.

[Corey Bryant (corey.bryant)]

Regression testing successful on stein-proposed:

======
Totals
======
Ran: 92 tests in 975.6977 sec.
 - Passed: 84
 - Skipped: 8
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 0
Sum of execute time for each test: 447.3189 sec.

[Corey Bryant (corey.bryant)]

The verification of the Stable Release Update for python-openstacksdk has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Corey Bryant (corey.bryant)]

This bug was fixed in the package python-openstacksdk - 0.27.0-0ubuntu1~cloud0
---------------

 python-openstacksdk (0.27.0-0ubuntu1~cloud0) bionic-stein; urgency=medium
 .
   * d/gbp.conf: Create stable/stein branch.
   * New upstream point release for OpenStack Stein (LP: #1866361).
   * d/control: Align (Build-)Depends with upstream.