SRU ubuntu-dev-tools

Bug #1864571 reported by Steve Langasek
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-dev-tools (Ubuntu)
Invalid
High
Unassigned
Bionic
Fix Released
High
Brian Murray

Bug Description

[SRU justification]
The ubuntu-dev-tools package is primarily of interest to Ubuntu developers, providing tools for interacting with the Ubuntu archive and Ubuntu developer-centric services. Developers should have consistent behavior from these tools, regardless of which Ubuntu release they are using as a client.

Of personal interest to me is the change for grep-merges to work against team names, but any new features ought to be made available everywhere.

[test case]
The package from focal has a test suite that is run as an autopkgtest which should be good enough to ensure the tools basically work.

1) Install python-ubuntutools
2) Start a python console i.e. 'python'
3) from ubuntutools.question import YesNoQuestion

With the version of python-ubuntutools in -proposed this will not Traceback.

[Regression potential]
Things might fail to work when backporting to older releases. Barring that, any behavior changes are intentional, it is a feature that the tools work the same on stable releases as on the devel series.

description: updated
Changed in ubuntu-dev-tools (Ubuntu):
status: New → Invalid
Revision history for this message
Dan Streetman (ddstreet) wrote :

ubuntu-dev-tools in focal have py2 support removed, but bionic still supports py2. Are you suggesting adding py2 support back in for the bionic backport?

Revision history for this message
Steve Langasek (vorlon) wrote : Re: [Bug 1864571] Re: SRU ubuntu-dev-tools

On Tue, Feb 25, 2020 at 01:08:38PM -0000, Dan Streetman wrote:
> ubuntu-dev-tools in focal have py2 support removed, but bionic still
> supports py2. Are you suggesting adding py2 support back in for the
> bionic backport?

I wasn't suggesting it, because I hadn't realized there were bits exposed as
a public python module.

I suppose adding the python2 support back is necessary.

Revision history for this message
Mattia Rizzolo (mapreri) wrote :

This is the kind of things backports should be used for.

Are there no chances for a new backports team to appear and maintain those pockets?
Or, have the backports work like in debian when regular maintainers/developers upload and the team just checks the versioning is correct…

Revision history for this message
Steve Langasek (vorlon) wrote :

On Wed, Feb 26, 2020 at 01:56:24PM -0000, Mattia Rizzolo wrote:
> This is the kind of things backports should be used for.

Backports are not used by default, and the backports archive is for when you
want to give users the choice of the old vs the new behavior.

My argument is that for a development tool, we should expect the trunk
behavior consistently, and anything else is a bug; hence I believe it's
suitable for SRU.

Alternatively it could be distributed to Ubuntu developers as a snap (and
therefore be release-agnostic).

> Are there no chances for a new backports team to appear and maintain those
> pockets?

I think that is highly unlikely at this point.

Revision history for this message
Dan Streetman (ddstreet) wrote :

well ok, i see this was uploaded anyway...hope nobody was using python-ubuntutools in bionic, and ever needs an update to that binary pkg :-/

Revision history for this message
Łukasz Zemczak (sil2100) wrote : Proposed package upload rejected

An upload of ubuntu-dev-tools to bionic-proposed has been rejected from the upload queue for the following reason: "I think I need more clarification on this one before we can accept it (early reject). On the bug there is mention of it: this upload removes the python-ubuntutools package per the focal version. There were concerns of existing users using this package, but I see no attempts of making the situation better for those. What is the situation? Has it been assessed that there are no users of it? I also saw a proposal of re-adding the python2 support package with the backport, not to regress.".

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I'm uploading another version to UNAPPROVED, this time restoring python-ubuntutools. I had to patch it a bit to get the tests to pass under Python 2, nothing deep though. It does make it all a bit harder to be confident in though (the binaries use Python 3 in my upload, at least).

Changed in ubuntu-dev-tools (Ubuntu Bionic):
assignee: nobody → Michael Hudson-Doyle (mwhudson)
tags: added: id-5e34b1277b10d0770615b317
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Steve, or anyone else affected,

Accepted ubuntu-dev-tools into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-dev-tools/0.175~18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubuntu-dev-tools (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
Mathew Hodson (mhodson)
Changed in ubuntu-dev-tools (Ubuntu):
status: Invalid → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : [ubuntu-dev-tools/bionic] verification still needed

The fix for this bug has been awaiting testing feedback in the -proposed repository for bionic for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

tags: added: removal-candidate
Revision history for this message
Steve Langasek (vorlon) wrote :

This package has passed its autopkgtests, which was determined to be sufficient for SRU. Marking verification-done.

tags: added: verification-done-bionic
removed: verification-needed-bionic
tags: added: verification-needed-bionic
removed: removal-candidate verification-done-bionic
Steve Langasek (vorlon)
tags: added: verification-done-bionic
removed: verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-dev-tools - 0.175~18.04.1

---------------
ubuntu-dev-tools (0.175~18.04.1) bionic; urgency=medium

  * Backport to bionic. (LP: #1864571)
  * Relax debhelper dependency.
  * Restore (and test) python-ubuntudevtools package.
  * Invoke pylint in python/python3 agnostic way.
  * Sundry changes to restore Python 2 compatibility.

 -- Michael Hudson-Doyle <email address hidden> Mon, 17 Feb 2020 21:15:26 +1300

Changed in ubuntu-dev-tools (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for ubuntu-dev-tools has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Matthias Klose (doko) wrote :

this introduces a regression for ubuntu-archive-tools:

$ ./change-override -c main -S <pkg>
Traceback (most recent call last):
  File "./change-override", line 26, in <module>
    from ubuntutools.question import YesNoQuestion
ImportError: No module named ubuntutools.question

Changed in ubuntu-dev-tools (Ubuntu):
status: Fix Released → New
Changed in ubuntu-dev-tools (Ubuntu Bionic):
status: Fix Released → New
Changed in ubuntu-dev-tools (Ubuntu):
importance: Undecided → High
Changed in ubuntu-dev-tools (Ubuntu Bionic):
importance: Undecided → High
tags: added: rls-bb-incoming rls-gg-incoming
tags: added: regression-update
removed: rls-bb-incoming rls-gg-incoming verification-needed
tags: added: id-5f2c28248092a887b8599665
Revision history for this message
Scott Moser (smoser) wrote :

I'm pretty sure this change caused bug 1892879 also.
basically, the python-ubuntudevtools package is empty.

Steve Langasek (vorlon)
tags: added: fr-932
description: updated
Changed in ubuntu-dev-tools (Ubuntu Bionic):
assignee: Michael Hudson-Doyle (mwhudson) → Brian Murray (brian-murray)
status: New → In Progress
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Steve, or anyone else affected,

Accepted ubuntu-dev-tools into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-dev-tools/0.175~18.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubuntu-dev-tools (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
removed: verification-done-bionic
Revision history for this message
Brian Murray (brian-murray) wrote :

Verified the most recent test case on Ubuntu 18.04 LTS.

Preparing to unpack .../python-ubuntutools_0.175~18.04.2_all.deb ...
Unpacking python-ubuntutools (0.175~18.04.2) over (0.175~18.04.1) ...
Preparing to unpack .../ubuntu-dev-tools_0.175~18.04.2_all.deb ...
Unpacking ubuntu-dev-tools (0.175~18.04.2) over (0.175~18.04.1) ...
Preparing to unpack .../python3-ubuntutools_0.175~18.04.2_all.deb ...
Unpacking python3-ubuntutools (0.175~18.04.2) over (0.175~18.04.1) ...
Setting up python3-ubuntutools (0.175~18.04.2) ...
Setting up ubuntu-dev-tools (0.175~18.04.2) ...
Setting up python-ubuntutools (0.175~18.04.2) ...
Processing triggers for man-db (2.8.3-2ubuntu0.1) ...
bdmurray@clean-bionic-amd64:~$ python
Python 2.7.17 (default, Sep 30 2020, 13:38:04)
[GCC 7.5.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from ubuntutools.question import YesNoQuestion
>>>

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-dev-tools - 0.175~18.04.2

---------------
ubuntu-dev-tools (0.175~18.04.2) bionic; urgency=medium

  * Really restore python-ubuntudevtools package. (LP: #1892879, LP: #1864571)

 -- Brian Murray <email address hidden> Mon, 30 Nov 2020 13:42:33 -0800

Changed in ubuntu-dev-tools (Ubuntu Bionic):
status: Fix Committed → Fix Released
Kevin bush (akjk32002)
Changed in ubuntu-dev-tools (Ubuntu):
assignee: nobody → Kevin bush (akjk32002)
Steve Langasek (vorlon)
Changed in ubuntu-dev-tools (Ubuntu):
status: New → Opinion
status: Opinion → Invalid
assignee: Kevin bush (akjk32002) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.