Mahara

module_assessmentreport module giving errors on portfolio submission

Bug #1860050 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
Mahara 20.04.0
19.10
Fix Released
High
Unassigned
Mahara 19.10.2

Bug Description

If the submission system is external to mahara (eg LTI) rather than a group then the group id does not exist and so causes problems with submission.

Need to fix up code so that one can still submit without needing group id

Robert Lyon (robertl-9)
Changed in mahara:
importance: Undecided → Critical
importance: Critical → High
milestone: none → 20.04.0
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10720

Kristina Hoeppner (kris-hoeppner)
summary: - module_assessmentreport module giving erros on portfolio submission
+ module_assessmentreport module giving errors on portfolio submission
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10720
Committed: https://git.mahara.org/mahara/mahara/commit/dc566929ac3ae587e12451621a26d67472db3a62
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit dc566929ac3ae587e12451621a26d67472db3a62
Author: Robert Lyon <email address hidden>
Date: Fri Jan 17 11:01:18 2020 +1300

Bug 1860050: module_assessmentreport failing if submitting from external

If the place you are doing an assignment submission to is an external
system, eg via LTI, it fails as it tries to get a non-existant group id

Need to make it more robust

behatnotneeded

Change-Id: Ibb9b0504b46289d7258ca9e0a1da62a01d777f3d
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10771

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10771
Committed: https://git.mahara.org/mahara/mahara/commit/ed19c6d4e27633471d56a3926cb6b52bb3d87fe0
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit ed19c6d4e27633471d56a3926cb6b52bb3d87fe0
Author: Robert Lyon <email address hidden>
Date: Fri Jan 17 11:01:18 2020 +1300

Bug 1860050: module_assessmentreport failing if submitting from external

If the place you are doing an assignment submission to is an external
system, eg via LTI, it fails as it tries to get a non-existant group id

Need to make it more robust

behatnotneeded

Change-Id: Ibb9b0504b46289d7258ca9e0a1da62a01d777f3d
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit dc566929ac3ae587e12451621a26d67472db3a62)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10781

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Fix Committed → Fix Released
no longer affects: mahara/20.04
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.