pynacl should be a fix dependency
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
dkimpy |
Fix Released
|
Wishlist
|
Scott Kitterman |
Bug Description
File "/whatever/
valid = d.verify()
File "/usr/lib/
return self.verify_
File "/usr/lib/
pk, self.keysize, ktag = load_pk_
File "/usr/lib/
pk = nacl.signing.
NameError: name 'nacl' is not defined
with more and more dkim users publishing elliptic curve keys it would be reasonable to add pynacl as a required dependency. Additionally, pynacl requires cffi as backend.
I'm not sure I agree, particularly since adding something that needs to be compiled when installed via pip adds a lot of complexity. We should definitely have a better error message here though.