[Impact]
The DKMS package won't work with new kernels on bionic.
[Test case]
Install and load the modules.
[Regression potential]
This might break the functioning of the module.
[Comments for bionic]
The syscall change affects too many places on the source code and upstream only patch to make it compatible was based on a recent version of the code, which makes the backport hard.
Since the Eoan version remains compatible with older kernels, I believe a better approach is to bring the same version back to Bionic.
-----------------------------------
sysdig fails to build in bionic with the new linux-hwe-edge kernel:
$ uname -a
Linux b 5.3.0-21-generic #22~18.04.1-Ubuntu SMP Wed Oct 30 04:57:40 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
$ cat /etc/os-release
NAME="Ubuntu"
VERSION="18.04.3 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.3 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic
$ dpkg -l | grep sysdig
ii sysdig 0.19.1-1ubuntu1.1 amd64 system-level exploration and troubleshooting tool
ii sysdig-dkms 0.19.1-1ubuntu1.1 all system-level exploration and troubleshooting tool - kernel source
$ cat /var/lib/dkms/sysdig/0.19.1/build/make.log
DKMS make.log for sysdig-0.19.1 for kernel 5.3.0-21-generic (x86_64)
Mon Nov 25 14:31:30 -03 2019
make: Entering directory '/usr/src/linux-headers-5.3.0-21-generic'
CC [M] /var/lib/dkms/sysdig/0.19.1/build/main.o
/var/lib/dkms/sysdig/0.19.1/build/main.c: In function 'parse_socketcall':
/var/lib/dkms/sysdig/0.19.1/build/main.c:1263:2: error: too many arguments to function 'syscall_get_arguments'
syscall_get_arguments(current, regs, 0, 2, args);
^~~~~~~~~~~~~~~~~~~~~
In file included from /var/lib/dkms/sysdig/0.19.1/build/main.c:28:0:
./arch/x86/include/asm/syscall.h:112:20: note: declared here
static inline void syscall_get_arguments(struct task_struct *task,
^~~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/sysdig/0.19.1/build/main.c: In function 'drop_event':
/var/lib/dkms/sysdig/0.19.1/build/main.c:1399:4: error: too many arguments to function 'syscall_get_arguments'
syscall_get_arguments(current, regs, 0, 1, &close_arg);
^~~~~~~~~~~~~~~~~~~~~
In file included from /var/lib/dkms/sysdig/0.19.1/build/main.c:28:0:
./arch/x86/include/asm/syscall.h:112:20: note: declared here
static inline void syscall_get_arguments(struct task_struct *task,
^~~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/sysdig/0.19.1/build/main.c: In function 'page_fault_probe':
/var/lib/dkms/sysdig/0.19.1/build/main.c:2045:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
struct event_data_t event_data;
^~~~~~
scripts/Makefile.build:288: recipe for target '/var/lib/dkms/sysdig/0.19.1/build/main.o' failed
make[1]: *** [/var/lib/dkms/sysdig/0.19.1/build/main.o] Error 1
Makefile:1655: recipe for target '_module_/var/lib/dkms/sysdig/0.19.1/build' failed
make: *** [_module_/var/lib/dkms/sysdig/0.19.1/build] Error 2
make: Leaving directory '/usr/src/linux-headers-5.3.0-21-generic'
Hello Marcelo, or anyone else affected,
Accepted sysdig into bionic-proposed. The package will build now and be available at https:/
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-
Further information regarding the verification process can be found at https:/
N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.