PCBnew dimension always in inches

[Patrik Bachan]

Steps to reproduce in PCBnew:
- select mm mode
- pick layer you want to work in
- activate dimension tool
- start creating dimension

Result:
Dimensions is in inches even though mm mode was selected.
It is possible to change to mm afterwards editing dimension properties.

Secondary bug:
After changing to mm, probably due to conversion inaccuracies, dimension is not round number even on mm grid. You have to move some end a then move it back to point of measurement to force proper recalculation of dimension.

Expected result:
Dimensions is in mm according to selected mm mode.

Application: Pcbnew
Version: (5.99.0-402-g13df645af), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.67.0 OpenSSL/1.1.1d zlib/1.2.11 libidn2/2.3.0 libpsl/0.21.0 (+libidn2/2.2.0) libssh2/1.9.0 nghttp2/1.39.2
Platform: Linux 5.3.11-arch1-1 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Nov 22 2019 22:00:56
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.71.0
    OpenCASCADE Technology: 7.4.0
    Curl: 7.67.0
    Compiler: GCC 9.2.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=OFF
    KICAD_USE_OCC=ON
    KICAD_SPICE=ON

[Ian McInerney (imcinerney)]

The dimensions use the units that the board is in (set in the board properties).

[Patrik Bachan (xorly)]

Sorry, I didn't notice that one.

Secondary bug remains, should I open separate bug report?

[Ian McInerney (imcinerney)]

From your description of the second issue, it doesn't sound like there is a
bug. Changing the units of measure does not change where any items are
located. If you placed a dimension object using an inches grid, then it
will be located at that same spot when you switch the grid to mm. In fact,
having the behavior that you suggest seems like a serious flaw (since then
items move around when you change the grid settings).

On Sat, Nov 23, 2019 at 12:45 PM Patrik Bachan <email address hidden>
wrote:

> *** This bug is a duplicate of bug 1851820 ***
> https://bugs.launchpad.net/bugs/1851820
>
> Sorry, I didn't notice that one.
>
> Secondary bug remains, should I open separate bug report?
>
> --
> You received this bug notification because you are a member of KiCad Bug
> Squad, which is subscribed to KiCad.
> https://bugs.launchpad.net/bugs/1853690
>
> Title:
> PCBnew dimension always in inches
>
> Status in KiCad:
> New
>
> Bug description:
> Steps to reproduce in PCBnew:
> - select mm mode
> - pick layer you want to work in
> - activate dimension tool
> - start creating dimension
>
> Result:
> Dimensions is in inches even though mm mode was selected.
> It is possible to change to mm afterwards editing dimension properties.
>
> Secondary bug:
> After changing to mm, probably due to conversion inaccuracies, dimension
> is not round number even on mm grid. You have to move some end a then move
> it back to point of measurement to force proper recalculation of dimension.
>
> Expected result:
> Dimensions is in mm according to selected mm mode.
>
> Application: Pcbnew
> Version: (5.99.0-402-g13df645af), release build
> Libraries:
> wxWidgets 3.0.4
> libcurl/7.67.0 OpenSSL/1.1.1d zlib/1.2.11 libidn2/2.3.0
> libpsl/0.21.0 (+libidn2/2.2.0) libssh2/1.9.0 nghttp2/1.39.2
> Platform: Linux 5.3.11-arch1-1 x86_64, 64 bit, Little endian, wxGTK
> Build Info:
> Build date: Nov 22 2019 22:00:56
> wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+
> 3.24
> Boost: 1.71.0
> OpenCASCADE Technology: 7.4.0
> Curl: 7.67.0
> Compiler: GCC 9.2.0 with C++ ABI 1013
>
> Build settings:
> KICAD_SCRIPTING=ON
> KICAD_SCRIPTING_MODULES=ON
> KICAD_SCRIPTING_PYTHON3=ON
> KICAD_SCRIPTING_WXPYTHON=ON
> KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
> KICAD_SCRIPTING_ACTION_MENU=ON
> BUILD_GITHUB_PLUGIN=ON
> KICAD_USE_OCE=OFF
> KICAD_USE_OCC=ON
> KICAD_SPICE=ON
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1853690/+subscriptions
>

[Patrik Bachan (xorly)]

See attached video. I am using 1mm grid, project default dimension unit is set to inches.

> Changing the units of measure does not change where any items are
located.

I don't really know cause of this. Value of dimension is converted with an error. Once you try to move end of dimension, value gets recalculated to correct value.

It's same thing when you create mm dimension on inch grid and then switch unit to inches. There is an conversion error.

[Ian McInerney (imcinerney)]

Ah, OK. So you mean there is an issue in the number of digits displayed when we convert the units. Yes, please open a new issue for that so we can fix it. The dimension should use the correct number of digits at all times.