[21.10 FEAT] Valgrind support for new s390 hardware

Bug #1853271 reported by bugproxy
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu on IBM z Systems
Fix Released
High
Skipper Bug Screeners
valgrind (Ubuntu)
Fix Released
Undecided
Graham Inggs

Bug Description

Add support of new s390 hardware instructions to Valgrind. This is required when running applications built for z15 under Valgrind for debugging purposes.

The enablement of Valgrind with new instructions is crucial since the distro build environments use Valgrind for build validation of e.g. Glibc. Valgrind new s390 hardware support is a hard requirement for all distro builds with an ALS to this new s390 hardware

bugproxy (bugproxy)
tags: added: architecture-s39064 bugnameltc-179792 severity-high targetmilestone-inin2004
Changed in ubuntu:
assignee: nobody → Skipper Bug Screeners (skipper-screen-team)
affects: ubuntu → valgrind (Ubuntu)
Revision history for this message
Frank Heimes (fheimes) wrote :

I'll mark this as a duplicate of LP 1825343,
however, will make a note to consider this for the upcoming release notes.

summary: - [20.04 FEAT] Valgrind support for new s390 hardware
+ [20.10 FEAT] Valgrind support for new s390 hardware
Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2019-11-27 02:41 EDT-------
Moved to 20.10, will not make it into 20.04

tags: added: targetmilestone-inin2010
removed: targetmilestone-inin2004
summary: - [20.10 FEAT] Valgrind support for new s390 hardware
+ [21.04 FEAT] Valgrind support for new s390 hardware
Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2020-08-19 08:27 EDT-------
Feature moved to 21.04. Will not make it time for 20.10. Inclusion targeted for valgrind 3.17.

tags: added: targetmilestone-inin2104
removed: targetmilestone-inin2010
summary: - [21.04 FEAT] Valgrind support for new s390 hardware
+ [21.10 FEAT] Valgrind support for new s390 hardware
Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2021-01-26 02:58 EDT-------
Feature will not make it for 21.04, moved to 21.10

tags: added: targetmilestone-inin2110
removed: targetmilestone-inin2104
Revision history for this message
Frank Heimes (fheimes) wrote :

This is no longer a duplicate
things are now decoupled
and this portion now slipped to 21.10

Changed in ubuntu-z-systems:
status: New → Incomplete
Changed in valgrind (Ubuntu):
status: New → Incomplete
Changed in ubuntu-z-systems:
importance: Undecided → High
assignee: nobody → Skipper Bug Screeners (skipper-screen-team)
Changed in valgrind (Ubuntu):
assignee: Skipper Bug Screeners (skipper-screen-team) → nobody
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for valgrind (Ubuntu) because there has been no activity for 60 days.]

Changed in valgrind (Ubuntu):
status: Incomplete → Expired
tags: added: fr-1390
Revision history for this message
Frank Heimes (fheimes) wrote :

@IBM Any indication about an upstream version the improved s390x support will end up?

Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2021-05-20 11:55 EDT-------
> @IBM Any indication about an upstream version the improved s390x support
> will end up?
The progress is tracked upstream here: https://bugs.kde.org/show_bug.cgi?id=432387

Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2021-05-28 12:04 EDT-------
> The progress is tracked upstream here:
> https://bugs.kde.org/show_bug.cgi?id=432387
I've finished up a patch and attached it to that Bug. Upstream approval is still pending.

Simon Chopin (schopin)
information type: Private → Public
Changed in valgrind (Ubuntu):
status: Expired → In Progress
assignee: nobody → Simon Chopin (schopin)
Revision history for this message
Simon Chopin (schopin) wrote :

Here's a debdiff incorporating the above patchset into our version of Valgrind

Frank Heimes (fheimes)
Changed in ubuntu-z-systems:
status: Incomplete → In Progress
Revision history for this message
Simon Chopin (schopin) wrote :

My apologies, it turns out I didn't actually test-build on s390x. After doing so, the build fails. I have a potential fix, waiting on the build to finish.

Revision history for this message
Simon Chopin (schopin) wrote :

Fixed version (some helper functions and macros were missing)

Graham Inggs (ginggs)
Changed in valgrind (Ubuntu):
assignee: Simon Chopin (schopin) → Graham Inggs (ginggs)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package valgrind - 1:3.17.0-0ubuntu2

---------------
valgrind (1:3.17.0-0ubuntu2) impish; urgency=medium

  * d/p/lp-1853271/Bug-432387-z15-support*.patch
    adding support for IBM z15 instructions to Valgrind (LP: #1853271)
  * d/p/0001-s390x-Add-convenience-function-mkV128.patch added in support
    of the z15 patchset.

 -- Simon Chopin <email address hidden> Wed, 28 Jul 2021 12:23:48 +0200

Changed in valgrind (Ubuntu):
status: In Progress → Fix Released
Frank Heimes (fheimes)
Changed in ubuntu-z-systems:
status: In Progress → Fix Released
Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2021-08-25 07:24 EDT-------
Fix available in Impish / U21.10, hence closing.
IBM BZ status: ->CLOSED

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.