Allowing a site admin to set an external app owner to be someone other than themselves

[Robert Lyon]

To allow the external app owner to be an owner of specific webservice rules and not make things all tied to the site admin user

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10610

[Rangi Daymond (rangid)]

- Code/Gerrit: https://reviews.mahara.org/#/c/10610/ Patch set 4
- Browser tested: Chrome
- Theme: Raw
- No browser or theme testing needed

Preconditions:
1. Mahara site version 19.10 present.
2. Institution1 is present.
3. Site admin has the following 'Settings for external applications' saved with Owner 'admin':
   - 'LTI integration' 'ExternalApp#1' 'No institution'
   - 'LTI integration' 'ExternalApp2' for 'Institution1'
   - 'Mahara Mobile API' 'ExternalApp-3' for Institution1
4. The following additional people exist with the given roles:
   - Inst1Admin has the institution admin role in Institution1
   - Staff has the site staff role (no institution)
   - Inst1Student has no special role in Institution1
   - PersonA no role (no institution) - suspended

Test scenario 1: The owner can be updated for existing external applications.

Test steps:
1. Upgrade the site to use patch.
2. Login as site admin and navigate to 'Admin menu' > 'Web services' > 'External apps'.
Expected result ✔ : The above three external applications are displayed correctly in the 'Settings for external applications' table. In all 3 cases the owner is 'admin'.
3. Click the 'Edit' button for 'ExternalApp#1' and change the owner from 'admin' to 'Staff' by deleting the 'admin' and searching for 'Staff' and selecting that account. Click the 'Save' button.
Expected result ✔ : The change is saved and 'Staff' displays as the owner in the 'Settings for external applications' table.
4. Click the 'Edit' button for 'ExternalApp2' and change the owner from 'admin' to 'Inst1Admin' by deleting the 'admin' and searching for 'Inst1Admin' and selecting that account. Click the 'Save' button.
Expected result ✔ : The change is saved and 'Inst1Admin' displays as the owner in the 'Settings for external applications' table.
5. Click the 'Edit' button for 'ExternalApp-3' settings and change the owner from 'admin' to 'Inst1Student'by deleting the 'admin' and searching for 'Inst1Student' and selecting that account. Click the 'Save' button.
Expected result ✔ : The change is saved and 'Inst1Student' displays as the owner in the 'Settings for external applications' table.
6. Log out, then log in again and return to 'Admin menu' > 'Web services' > 'External apps'.
Expected result ✔ : The changes persist.

Test scenario 2: A new external application can be added for an owner other than 'admin'

Test steps:
7. Navigate to 'Admin menu' > 'Web services' > 'External apps', enter 'NewExtApp1' in 'Application:' and select to 'Add' a new external application for an owner other than 'admin'.
Expected results: The new external application is created and 'Registration...' page is displayed with default values:
 - ✔ The 'Service owner' field label is marked as required with a red asterisk,
 - ✔ The owner default value is 'admin',
 - ✔ The default owner can be removed,
 - ✔ At least one and only one owner must be selected,
 - If no owner is selected then 'Save' is clicked:
    ✔ - Display the general page top error message,
    ✔ - Display 'Need to set an owner for this service' underneath the 'Service owner' field
    ✔ - Once an owner is selected and 'Save' is clicked again
          ✔ - clear both er...

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10610
Committed: https://git.mahara.org/mahara/mahara/commit/e570cce69b6b9e6151e3d24fc305ebd8d4f4295f
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit e570cce69b6b9e6151e3d24fc305ebd8d4f4295f
Author: Robert Lyon <email address hidden>
Date: Fri Nov 15 10:11:08 2019 +1300

Bug 1852644: Allowing admin to set external app owner to be another user

behatnotneeded

Change-Id: I6224fbc3f449d0e205bf99f4b0f46fa2e76323bf
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10773

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10773
Committed: https://git.mahara.org/mahara/mahara/commit/8c1d72d1db940f59783c1534a786f97098c99479
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit 8c1d72d1db940f59783c1534a786f97098c99479
Author: Robert Lyon <email address hidden>
Date: Fri Nov 15 10:11:08 2019 +1300

Bug 1852644: Allowing admin to set external app owner to be another user

behatnotneeded

Change-Id: I6224fbc3f449d0e205bf99f4b0f46fa2e76323bf
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit e570cce69b6b9e6151e3d24fc305ebd8d4f4295f)

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10781