r8168-dkms 8.047.04-1 fails to build with 5.4 kernel

Bug #1852616 reported by Thadeu Lima de Souza Cascardo
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
r8168 (Ubuntu)
Fix Released
Medium
Thadeu Lima de Souza Cascardo
Bionic
Fix Released
Medium
Thadeu Lima de Souza Cascardo

Bug Description

[Impact]
DKMS fails to build with 5.4 kernel.

[Test case]
Test that it builds with older kernels as well.

[Regression potential]
It might fail to build with older kernels.

Changed in r8168 (Ubuntu):
assignee: nobody → Thadeu Lima de Souza Cascardo (cascardo)
Changed in r8168 (Ubuntu Bionic):
assignee: nobody → Thadeu Lima de Souza Cascardo (cascardo)
importance: Undecided → Medium
Changed in r8168 (Ubuntu):
importance: Undecided → Medium
Changed in r8168 (Ubuntu Bionic):
status: New → In Progress
Changed in r8168 (Ubuntu):
status: New → In Progress
Revision history for this message
Thadeu Lima de Souza Cascardo (cascardo) wrote :
Revision history for this message
Thadeu Lima de Souza Cascardo (cascardo) wrote :
tags: added: patch
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package r8168 - 8.047.04-1ubuntu1

---------------
r8168 (8.047.04-1ubuntu1) focal; urgency=medium

  * Fix build with Linux 5.4 (LP: #1852616)

 -- Thadeu Lima de Souza Cascardo <email address hidden> Thu, 14 Nov 2019 14:22:34 -0300

Changed in r8168 (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Thadeu, or anyone else affected,

Accepted r8168 into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/r8168/8.045.08-2ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in r8168 (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Thadeu Lima de Souza Cascardo (cascardo) wrote :

bionic version works fine with linux-hwe-edge-5.3.0-23-generic

Unpacking r8168-dkms (8.045.08-2ubuntu1) over (8.045.08-2) ...
Setting up r8168-dkms (8.045.08-2ubuntu1) ...
Loading new r8168-8.045.08 DKMS files...
Building for 5.3.0-21-generic 5.3.0-23-generic
Module build for kernel 5.3.0-21-generic was skipped since the
kernel headers for this kernel does not seem to be installed.
Building initial module for 5.3.0-23-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

r8168:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.3.0-23-generic/updates/dkms/

depmod....

Revision history for this message
Thadeu Lima de Souza Cascardo (cascardo) wrote :

Also builds fine with 5.0.0-30-generic.

$ sudo dkms build r8168/8.045.08 -k 5.0.0-30-generic

Kernel preparation unnecessary for this kernel. Skipping...

Building module:
cleaning build area.....
make -j1 KERNELRELEASE=5.0.0-30-generic -C /lib/modules/5.0.0-30-generic/build M=/var/lib/dkms/r8168/8.045.08/build......................
Signing module:
 - /var/lib/dkms/r8168/8.045.08/5.0.0-30-generic/x86_64/module/r8168.ko
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
cleaning build area.....

DKMS: build completed.

Revision history for this message
Thadeu Lima de Souza Cascardo (cascardo) wrote :

Finally, builds fine with 4.15.0-68-generic.

$ sudo dkms build r8168/8.045.08 -k 4.15.0-68-generic

Kernel preparation unnecessary for this kernel. Skipping...

Building module:
cleaning build area......
make -j1 KERNELRELEASE=4.15.0-68-generic -C /lib/modules/4.15.0-68-generic/build M=/var/lib/dkms/r8168/8.045.08/build.......................
Signing module:
 - /var/lib/dkms/r8168/8.045.08/4.15.0-68-generic/x86_64/module/r8168.ko
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
cleaning build area.....

DKMS: build completed.

tags: added: verification-done-bionic
removed: verification-needed-bionic
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package r8168 - 8.045.08-2ubuntu1

---------------
r8168 (8.045.08-2ubuntu1) bionic; urgency=medium

  * linux-5.3.patch: Fix build with Linux 5.3 (LP: #1852616)
  * linux-5.4.patch: Fix build with Linux 5.4 (LP: #1852616)

 -- Thadeu Lima de Souza Cascardo <email address hidden> Mon, 18 Nov 2019 16:11:50 -0300

Changed in r8168 (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for r8168 has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.