When placing hold on an item, searching/selecting patron does not always enable the submit button

[Nathan Eady]

I personally have been seeing this at least since mid 2017, but other staff here (at least three distinct people) have only very recently started to complain of it, saying they've never experienced it before. We're seeing it live on cool-cat.org.

Evergreen version: 3.3.4 currently; happened _to me_, but not to the other staff members who are now complaining of it, on earlier versions.

Reproducibility: varies
Steps to Reproduce:
 1. Log into the web staff client.
 2. Search -> Search the Catalog
 3. Enter search criteria.
    (For Title, I typed in "The Kitchen".)
    (Under Search Format, I chose Movies & TV)
 4. Click the Search button.
 5. In the search results, click the "Place Hold" link next to a desired title.
 6. Click the Patron Search button.
 7. Enter the last and first names of a patron.
 8. Under Patron Search Results, click one entry on the list.
 9. Click the Select button.

Expected Results:
The patron's barcode should be filled in, and the Submit button should be enabled.

Actual Results:
The patron's barcode is filled in, but the Submit button is not always enabled. If it remains "grayed out", clicking on it does nothing, and it is not clear how to get the request to submit.

Reproducibility Notes:
When this happens, repeating steps (e.g., repeating steps 6-9, or steps 2-9, or even logging out and starting again from step 1) doesn't seem to make any difference. It seems like any given patron/item/workstation/staff-login combination either reliably triggers the bug, or not. I have not determined any particular pattern to which combinations do or do not trigger it.

Workaround:
Once the patron barcode is filled in, click on it to place the keyboard cursor in that form element, and press the Enter key. At least in some cases, this will cause the Submit button to become enabled. Only recently discovered this one, not sure if it works 100% of the time.

Other Workaround:
Pull up the patron's account first, select the Holds tab, and place the hold for there, searching for the item. This always works correctly.

Screenshots will be forthcoming shortly.

[Dan Briem (dbriem)]

This might be related to the fix for https://bugs.launchpad.net/evergreen/+bug/1778606.

If the previous version of opac/parts/place_hold.tt2 file is a cached template on your server, a patron search selection will trigger a call to no_hold_submit(), which is not in the current version of opac/staff.js.

You could consult your system administrator to ensure that your server isn't caching the previous version of the template to see if that resolves the issue.

[Nathan Eady (mrmcquack)]

We checked with our consortium admin about opac/parts/place_hold.tt2 a while back, and at first I wasn't sure (because the problem was always intermittent), and then this sort of slipped off my radar; but the tag change just brought my attention back to it, and I don't think I've seen the issue since, certainly not recently, so that was probably the issue.

[Terran McCanna (tmccanna)]

This is not an issue with the Angular staff catalog.