Backport MPLS patches from 5.3 to 4.15
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Po-Hsu Lin | ||
Disco |
Won't Fix
|
Undecided
|
Po-Hsu Lin |
Bug Description
== SRU Justification ==
Mellanox is requesting a backport of the following commit IDs from 5.3
back to 5.0 and 4.15:
* 5dc9520bf04a ("net/mlx5e: Report netdevice MPLS features")
* 8b6912a50193 ("net: vlan: Inherit MPLS features from parent device")
* 2e770b507ccd ("net: bonding: Inherit MPLS features from slave devices")
* e4683f35f8e5 ("net/mlx5e: Move to HW checksumming advertising")
Netdevice HW MPLS features are not passed from device driver's netdevice
to upper netdevice, specifically VLAN and bonding netdevice which are
created by the kernel when needed.
This prevents enablement and usage of HW offloads, such as TSO and
checksumming for MPLS tagged traffic when running via VLAN or bonding
interface.
The patches introduce changes to the initialization steps of the VLAN
and bonding netdevices to inherit the MPLS features from lower
netdevices to allow the HW offloads.
== Fix ==
* 5dc9520bf04a ("net/mlx5e: Report netdevice MPLS features")
* 8b6912a50193 ("net: vlan: Inherit MPLS features from parent device")
* 2e770b507ccd ("net: bonding: Inherit MPLS features from slave devices")
* e4683f35f8e5 ("net/mlx5e: Move to HW checksumming advertising")
The first two patches can be cherry-picked into Disco, and the rest
will require some context adjustment.
== Test ==
Test kernels can be found here:
https:/
Kernel tested with positive test result and approved by their QA.
== Regression Potential ==
Low, changes just for adding MPLS feature and comes with positive
test result.
== Original Bug Report ==
Mellanox is requesting a backport of the following commit IDs from 5.3 back to 4.15.
Netdevice HW MPLS features are not passed from device driver's netdevice to upper netdevice, specifically VLAN and bonding netdevice which are created by the kernel when needed.
This prevents enablement and usage of HW offloads, such as TSO and checksumming for MPLS tagged traffic when running via VLAN or bonding interface.
The patches introduce changes to the initialization steps of the VLAN and
bonding netdevices to inherit the MPLS features from lower netdevices to allow the HW offloads.
Ariel Levkovich (2):
net: bonding: Inherit MPLS features from slave devices
net: vlan: Inherit MPLS features from parent device
drivers/
net/8021q/
2 files changed, 12 insertions(+)
https://<email address hidden>
Commit IDs (All landed in 5.3)
600bb0318c18e96
8b6912a5019356d
2e770b507ccde8e
CVE References
description: | updated |
Changed in linux (Ubuntu Bionic): | |
status: | Confirmed → In Progress |
Changed in linux (Ubuntu Bionic): | |
status: | In Progress → Incomplete |
description: | updated |
Changed in linux (Ubuntu Bionic): | |
assignee: | nobody → Po-Hsu Lin (cypressyew) |
Changed in linux (Ubuntu): | |
status: | Incomplete → Invalid |
Changed in linux (Ubuntu Disco): | |
assignee: | nobody → Po-Hsu Lin (cypressyew) |
status: | New → Triaged |
Changed in linux (Ubuntu Bionic): | |
status: | Incomplete → In Progress |
Changed in linux (Ubuntu Disco): | |
status: | Triaged → In Progress |
Changed in linux (Ubuntu Bionic): | |
status: | In Progress → Fix Committed |
Changed in linux (Ubuntu Disco): | |
status: | In Progress → Fix Committed |
Changed in linux (Ubuntu Disco): | |
status: | Fix Committed → Won't Fix |
This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:
apport-collect 1851446
and then change the status of the bug to 'Confirmed'.
If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.
This change has been made by an automated script, maintained by the Ubuntu Kernel Team.