CSS From Library Setting Needs to have permissions

[Rogan Hamby]

This is a follow up to #1849152. I will post a patch shortly to add permissions for it.

[Rogan Hamby (rogan-hamby)]

Patch available here:

08ebe0c801299262b27c514e2cedb3dc83223dbf

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=08ebe0c801299262b27c514e2cedb3dc83223dbf

This adds an view and update permission as well as updates the release notes to mention them.

[Jeff Godin (jgodin)]

Thanks, Rogan!

My initial reaction was that we only need an update perm for this org unit setting.

Under what circumstances can you see wanting to require a specific permission to view the value?

Also, since bug 1849152 has already been committed to master and the database upgrade script given a number, I think a different approach will be required for the database changes in this followup work.

I don't know that we have that explicitly documented, but give a shout on irc or the dev list if you need advice there (and this wasn't just a simple oversight).

[Rogan Hamby (rogan-hamby)]

I can see arguments for combining versus doing separate. At this point it's so close in time I think it would be easier to encapsulate it though if the core committers feel it's better to stick to separate on principle (or this drags in being tested) doing it separate isn't a big deal.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=20253abae3dd4e21f8bbc2db8568bef27834a78c

[Galen Charlton (gmc)]

I see no reason for a separate view permission; protecting update is sufficient IMO. Also, it does indeed need to be a separate patch rather than updating the existing schema update script.

[Rogan Hamby (rogan-hamby)]

patch with just update permission https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=ef47a41ef29520d46290989ed1d338a070fe2587

[Jason Boyer (jboyer)]

I've tested this and it works as expected, signoff branch is here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1849683_permission_signoff / working/user/jboyer/lp1849683_permission_signoff

[Dan Wells (dbw2)]

Just a note, the INSERT into config.org_unit_setting_type in the seed file still needs the translation wrapper for those strings. Check out examples starting on or around line 15291.

[Jason Boyer (jboyer)]

Thanks for the catch Dan, I've force-pushed an update to that branch that addresses that and a couple other issues.

[Jason Boyer (jboyer)]

In the interest of getting this in before 3.5.0 is released I've pushed this patch with changes based on Dan's feedback (and a formatting change for the release notes) to master. Thanks everyone!

[Jane Sandberg (sandbergja)]

This was released in 3.5.0. I don't know how to target this to a past release, though.