Fix 'parentheses around assignment used as truth value' warnings
Bug #1849621 reported by
أحمد المحمودي (Ahmed El-Mahmoudy)
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| gEDA |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
The attached patch fixes 'parentheses around assignment used as truth value' warnings in some xorn tests
Revision history for this message
| أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy) wrote | #1 |
Revision history for this message
| Roland Lutz (rlutz) wrote | #2 |
| Changed in geda: | |
| status: | New → Fix Committed |
Revision history for this message
| Roland Lutz (rlutz) wrote | #3 |
| Changed in geda: | |
| milestone: | none → 1.10.1 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Thank you.
It would be helpful if you could generate future diffs with `git format-patch', e.g.:
git format-patch HEAD^
This way, the diff is already in the format `git am' expects.
Also, it is common to reference the bug number with "Closes-bug: lp-1849621" at the end of the commit message, separated by an empty line (see commit be34592 for an example).
Which warning options do you use, BTW? I can't seem to get these warnings even with `-Wall -Wextra'.
fixed in 9ccf689d4d2ef5f
(branch `xorn', awaits merge)