The -p option does not properly accept 'call_tree'

[Benjamin Kudria]

Binary package hint: ruby-prof

The script /usr/bin/ruby-prof is missing a conditional when parsing the -p option, and thus -p call_tree acts exactly the same as -p flat . This is incorrect behavior, and simply adding the conditional restores proper behavior. The call_tree format is a standardized format most commonly parsed by KDE's KCacheGrind. A simple patch to /usr/bin/ruby-prof is attached.

[Daniel Holbach (dholbach)]

To get your fix (or workaround) included in Ubuntu, try transforming it into a patch (http://wiki.ubuntu.com/PackagingGuide/Recipes/Debdiff) and submitting it for review (http://wiki.ubuntu.com/SponsorshipProcess).

[Benjamin Kudria (bkudria)]

Thanks, Daniel, I'll follow these steps.

[Daniel Holbach (dholbach)]

Setting to incomplete for now - set back to 'new' if you've attached the debdiff and subscribed the sponsoring team.

[Benjamin Kudria (bkudria)]

The debdiff to fix the bug is attached.

[Benjamin Kudria (bkudria)]

Setting as per: https://wiki.ubuntu.com/MOTU/Sponsorship/SponsorsQueue

[Daniel Hahler (blueyed)]

Fixed in 0.5.2-1ubuntu1.

Thank you for your contribution, I've uploaded it.
I've found a minor issue (lintian warning about the Standards-Version) and fixed it right away.
Unfortunately, I "hijacked" your upload this way, instead of really sponsoring it (it does not appear as uploaded by you now).
I should have rather asked you to change your debdiff or just ignore this minor issue in there.
This is especially annoying, because I've overlooked the missing "LP: #184946" reference in debian/changelog. Argh..
Sorry that I've messed up your first debdiff/request for sponsorship.

But at least it's now fixed in Ubuntu. Thank you.
Please submit the patch to upstream and/or Debian. You can use the "submittodebian" script from the ubuntu-dev-tools package to do this.

[Benjamin Kudria (bkudria)]

On Thursday, January 31 2008, Daniel Hahler wrote:
> Fixed in 0.5.2-1ubuntu1.
>
> Thank you for your contribution, I've uploaded it.
> I've found a minor issue (lintian warning about the Standards-Version) and
> fixed it right away. Unfortunately, I "hijacked" your upload this way,
> instead of really sponsoring it (it does not appear as uploaded by you
> now). I should have rather asked you to change your debdiff or just ignore
> this minor issue in there. This is especially annoying, because I've
> overlooked the missing "LP: #184946" reference in debian/changelog. Argh..
> Sorry that I've messed up your first debdiff/request for sponsorship.

It's ok, it's no big deal.

> But at least it's now fixed in Ubuntu. Thank you.
> Please submit the patch to upstream and/or Debian. You can use the
> "submittodebian" script from the ubuntu-dev-tools package to do this.

All done.

Thanks for the help!

-Ben

--
http://ben.kudria.net | Jabber: <email address hidden>