core18 builds failing on bionic due to bash typo

[Łukasz Zemczak]

[Impact]

A terrible typo has been backported to bionic in auto/build, missed by us not running bionic core18 builds. Without this fix any core based images will fail to build with the following error:

./auto/build: 50: [: missing ]
make: *** config/livecd.ubuntu-core-raspi3-gadget: No such file or directory. Stop.
Build failed

[Test Case]

Run a bionic ubuntu-core 18 livefs build and make sure it succeeds.

[Regression Potential]

None, this is just a silly-typo fix in bash.

[Adam Conrad (adconrad)]

Hello Łukasz, or anyone else affected,

Accepted livecd-rootfs into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.525.33 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Just ran a bionic based ubuntu-core image build via cdimage (with proposed enabled) and the builds succeeded:
https://people.canonical.com/~ubuntu-archive/cd-build-logs/ubuntu-core/bionic/daily-live-20191107.log

Confirmed the typo is no longer hindering the image builds.

[Launchpad Janitor (janitor)]

This bug was fixed in the package livecd-rootfs - 2.525.33

---------------
livecd-rootfs (2.525.33) bionic; urgency=medium

  * Add support for the 'kassel' subflavor of UC18 images. (LP: #1850674)

livecd-rootfs (2.525.32) bionic; urgency=medium

  * Fix a terrible typo in auto/build that causes all core18 builds to fail on
    this series (LP: #1849343).
  * Backport 999-ubuntu-image-customization.chroot to have a common place for
    our cloud-init datasource. Add some modifications on top to make sure the
    legacy raspi2 configuration stays the same (LP: #1849472).
  * Backport enabling of adding extra snaps to ubuntu-core images via the
    EXTRA_SNAPS environment (LP: #1849491).

 -- Łukasz 'sil2100' Zemczak <email address hidden> Wed, 30 Oct 2019 18:09:02 +0100

[Steve Langasek (vorlon)]

The verification of the Stable Release Update for livecd-rootfs has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.