peer assessment : details in modal should not show block content

Bug #1848959 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Cecilia Vela Gurovic

Bug Description

A user with a 'peer' role should not be able to see the block content of the page.

to test:
- create a page with a peer assessment block and an image block
- share it with another user and set the role to 'peer'
- login with the peer user
- got to the page to be assessed, you don't see content of the image block, only the title.
- click on the details button
- click on the 'Add comment/Details' link on top of the image block

Expected result: a user with a 'peer' role should not see any block content other than the peer assessment block and sign-off block

Actual result: the modal opens and the image is displayed

Tags: regression
tags: added: regression
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10459

Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10459
Committed: https://git.mahara.org/mahara/mahara/commit/947f3f898440d1a41a8e0c88ded9681a72594778
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 947f3f898440d1a41a8e0c88ded9681a72594778
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Oct 21 12:38:02 2019 +1300

Bug 1848959: peer assessment: dont display 'Details' button for peer only roles

behatnotneeded

Change-Id: I5380cddc0871cb1faa849eed9b4f91b1b646dbde

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10474

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10474
Committed: https://git.mahara.org/mahara/mahara/commit/446335f74f30e5c2eab9077e137e8d89025178bc
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit 446335f74f30e5c2eab9077e137e8d89025178bc
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Oct 21 12:38:02 2019 +1300

Bug 1848959: peer assessment: dont display 'Details' button for peer only roles

behatnotneeded

Change-Id: I5380cddc0871cb1faa849eed9b4f91b1b646dbde
(cherry picked from commit 947f3f898440d1a41a8e0c88ded9681a72594778)

Lisa Seeto (lisaseeto)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.