rev 7906 failed to compile against Eoan generic kernel 5.3.0-19-generic: implicit declaration of function ‘ktime_get_boot_ns’

Bug #1848922 reported by You-Sheng Yang
44
This bug affects 8 people
Affects Status Importance Assigned to Milestone
backport-iwlwifi-dkms (Ubuntu)
Fix Released
Critical
You-Sheng Yang
Eoan
Fix Released
Critical
You-Sheng Yang
Focal
Fix Released
Critical
You-Sheng Yang

Bug Description

[SRU Justification]

[Impact]
FTBFS against v5.3 kernels on Eoan/Focal.

[Fix]
* Backport fix from upstream commit f47729b94e11 (backport: rename ktime_get_boot_ns for v5.3+).
* Also updates -fcf-protection=none usage for bug
1830961
.

[Test Case]
Verified DKMS module build on linux-oem/linux-oem-osp1/linux-generic >= 4.10 kernels on series Xenial/Bionic/Cosmic/Disco/Eoan and Focal.

[Regression Risk]
Low. There is no functional changes in comparison to 7906-0ubuntu1.

======== original bug description ========

/var/lib/dkms/backport-iwlwifi/7906/build/drivers/net/wireless/intel/iwlwifi/mvm/utils.c: In function ‘iwl_mvm_get_sync_time’:
/var/lib/dkms/backport-iwlwifi/7906/build/drivers/net/wireless/intel/iwlwifi/mvm/utils.c:1468:14: error: implicit declaration of function ‘ktime_get_boot_ns’; did you mean ‘ktime_get_raw_ns’? [-Werror=implicit-function-declaration]
 1468 | *boottime = ktime_get_boot_ns();
      | ^~~~~~~~~~~~~~~~~
      | ktime_get_raw_ns
cc1: some warnings being treated as errors
make[9]: *** [scripts/Makefile.build:290: /var/lib/dkms/backport-iwlwifi/7906/build/drivers/net/wireless/intel/iwlwifi/mvm/utils.o] Error 1
make[8]: *** [scripts/Makefile.build:519: /var/lib/dkms/backport-iwlwifi/7906/build/drivers/net/wireless/intel/iwlwifi/mvm] Error 2
make[8]: *** Waiting for unfinished jobs....

ProblemType: Bug
DistroRelease: Ubuntu 19.10
Package: backport-iwlwifi-dkms 7906-0ubuntu1
ProcVersionSignature: Ubuntu 5.3.0-19.20-generic 5.3.1
Uname: Linux 5.3.0-19-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair wl
ApportVersion: 2.20.11-0ubuntu8
Architecture: amd64
AudioDevicesInUse:
 USER PID ACCESS COMMAND
 /dev/snd/controlC1: vicamo 1680 F.... pulseaudio
 /dev/snd/controlC0: vicamo 1680 F.... pulseaudio
CurrentDesktop: KDE
Date: Sun Oct 20 18:37:16 2019
InstallationDate: Installed on 2019-09-28 (21 days ago)
InstallationMedia: Ubuntu 19.10 "Eoan Ermine" - Alpha amd64 (20190923)
MachineType: Apple Inc. MacBookPro11,1
PackageArchitecture: all
ProcFB: 0 i915drmfb
ProcKernelCmdLine: BOOT_IMAGE=/@/boot/vmlinuz-5.3.0-19-generic root=UUID=38c16714-8883-4c88-baae-df71ffa89972 ro rootflags=subvol=@ quiet splash vt.handoff=7
RelatedPackageVersions:
 linux-restricted-modules-5.3.0-19-generic N/A
 linux-backports-modules-5.3.0-19-generic N/A
 linux-firmware 1.183
SourcePackage: backport-iwlwifi-dkms
UpgradeStatus: No upgrade log present (probably fresh install)
dmi.bios.date: 06/13/2019
dmi.bios.vendor: Apple Inc.
dmi.bios.version: 156.0.0.0.0
dmi.board.asset.tag: Base Board Asset Tag#
dmi.board.name: Mac-189A3D4F975D5FFC
dmi.board.vendor: Apple Inc.
dmi.board.version: MacBookPro11,1
dmi.chassis.type: 10
dmi.chassis.vendor: Apple Inc.
dmi.chassis.version: Mac-189A3D4F975D5FFC
dmi.modalias: dmi:bvnAppleInc.:bvr156.0.0.0.0:bd06/13/2019:svnAppleInc.:pnMacBookPro11,1:pvr1.0:rvnAppleInc.:rnMac-189A3D4F975D5FFC:rvrMacBookPro11,1:cvnAppleInc.:ct10:cvrMac-189A3D4F975D5FFC:
dmi.product.family: Mac
dmi.product.name: MacBookPro11,1
dmi.product.sku: System SKU#
dmi.product.version: 1.0
dmi.sys.vendor: Apple Inc.

Related branches

Revision history for this message
You-Sheng Yang (vicamo) wrote :
Revision history for this message
You-Sheng Yang (vicamo) wrote :
Changed in backport-iwlwifi-dkms (Ubuntu):
status: New → Confirmed
Changed in backport-iwlwifi-dkms (Ubuntu):
assignee: nobody → You-Sheng Yang (vicamo)
Revision history for this message
You-Sheng Yang (vicamo) wrote :
Changed in backport-iwlwifi-dkms (Ubuntu):
status: Confirmed → In Progress
You-Sheng Yang (vicamo)
Changed in backport-iwlwifi-dkms (Ubuntu Eoan):
status: New → In Progress
assignee: nobody → You-Sheng Yang (vicamo)
importance: Undecided → Critical
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package backport-iwlwifi-dkms - 7906-0ubuntu2

---------------
backport-iwlwifi-dkms (7906-0ubuntu2) focal; urgency=low

  * debian/patches/0006-NOUPSTREAM-backport-rename-ktime_get_boot_ns-for-v5..patch
    - fix build against v5.3. (LP: #1848922)
  * debian/patches/0005-Makefile.kernel-pass-fno-stack-clash-protection-and-.patch
    - add -fcf-protection=none when using retpoline flags. (LP: #1830961)
    - drop -fno-stack-clash-protection for it's no longer necessary.

 -- You-Sheng Yang <email address hidden> Mon, 21 Oct 2019 20:22:27 +0800

Changed in backport-iwlwifi-dkms (Ubuntu Focal):
status: In Progress → Fix Released
Revision history for this message
You-Sheng Yang (vicamo) wrote :

I've pushed Eoan SRU changes to https://launchpad.net/~vicamo/+archive/ubuntu/ppa-1848922. Should be published some time later.

You-Sheng Yang (vicamo)
description: updated
Revision history for this message
Sithu Thwin (sithu-a) wrote :

Still getting error with -
Package: backport-iwlwifi-dkms
Version: 7906-0ubuntu1

I've attached crash log file.

Revision history for this message
You-Sheng Yang (vicamo) wrote :
You-Sheng Yang (vicamo)
description: updated
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello You-Sheng, or anyone else affected,

Accepted backport-iwlwifi-dkms into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/backport-iwlwifi-dkms/7906-0ubuntu2~19.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in backport-iwlwifi-dkms (Ubuntu Eoan):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-eoan
Revision history for this message
You-Sheng Yang (vicamo) wrote :

Verified version 7906-0ubuntu2~19.10.1 against following kernel headers:

  $ dkms status
  backport-iwlwifi, 7906, 4.15.0-1059-oem, x86_64: installed
  backport-iwlwifi, 7906, 5.0.0-1025-oem-osp1, x86_64: installed
  backport-iwlwifi, 7906, 5.3.0-23-generic, x86_64: installed

tags: added: verification-done-eoan
removed: verification-needed verification-needed-eoan
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for backport-iwlwifi-dkms has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package backport-iwlwifi-dkms - 7906-0ubuntu2~19.10.1

---------------
backport-iwlwifi-dkms (7906-0ubuntu2~19.10.1) eoan; urgency=low

  * debian/patches/0006-NOUPSTREAM-backport-rename-ktime_get_boot_ns-for-v5..patch
    - fix build against v5.3. (LP: #1848922)
  * debian/patches/0005-Makefile.kernel-pass-fno-stack-clash-protection-and-.patch
    - add -fcf-protection=none when using retpoline flags. (LP: #1830961)
    - drop -fno-stack-clash-protection for it's no longer necessary.

 -- You-Sheng Yang <email address hidden> Mon, 21 Oct 2019 20:22:27 +0800

Changed in backport-iwlwifi-dkms (Ubuntu Eoan):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.