Mahara

Doubleup of icons for alert messages

Bug #1848897 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
Mahara 19.10.0

Bug Description

With the change to have the alert icons be part of the css of the alert-* classes it means there can be a doubleup of the same icon if template also uses the <span class="icon*"></span> icon placeholder

Revision history for this message
Robert Lyon (robertl-9) wrote :

https://reviews.mahara.org/#/c/10452/

Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
milestone: none → 19.10rc2
Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
milestone: 19.10rc2 → 19.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10452
Committed: https://git.mahara.org/mahara/mahara/commit/c52f998097543bc8f418c9e2dd6922115c0b138f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c52f998097543bc8f418c9e2dd6922115c0b138f
Author: Robert Lyon <email address hidden>
Date: Sun Oct 20 12:15:16 2019 +1300

Bug 1848897: Removing doubleups of alert-* icons

- When adding a skin to a page
- When viewing a peerassment collection page as peer when no peer
block present
- including versioned page
- including html export of page

behatnotneeded

Change-Id: Idb39a80bd55875e0b4519790739f3804d68dc738
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10523

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10523
Committed: https://git.mahara.org/mahara/mahara/commit/820a8cbaf6b1f3310ecaa40b4eff841e30c2cd26
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 820a8cbaf6b1f3310ecaa40b4eff841e30c2cd26
Author: Robert Lyon <email address hidden>
Date: Sun Oct 20 12:15:16 2019 +1300

Bug 1848897: Removing doubleups of alert-* icons

- When adding a skin to a page
- When viewing a peerassment collection page as peer when no peer
block present
- including versioned page
- including html export of page

behatnotneeded

Change-Id: Idb39a80bd55875e0b4519790739f3804d68dc738
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c52f998097543bc8f418c9e2dd6922115c0b138f)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.