Skin text colour defaults should default to the theme colours

Bug #1846972 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Lisa Seeto

Bug Description

When you set up a skin, the font colours have a "Default" option. That is not the theme default colour though but the default colour seen on the page when getting to the skin's page for the first time.

Now that we are having header background images and we expect people to only want to change that background rather than build a full skin, it would be better if the "Default" option was the theme default colours for these options so that the only thing that changes is the header background image.

So instead of having "Default" as option, we'll have "Theme default" and no value saved for the skin as it will inherit the colour from the theme. This should be done for all colours on the "Text" tab.

To replicate:

1. Create a skin.
2. Change the background image.
3. Tick the "Default" options for the font colour options.
4. Add a "Text" block with a link to a page that has the skin.
Expected result: The link is displayed in the theme's regular link colour.
Actual result: The link is displayed in blue, i.e. the skin's default colour.

Changed in mahara:
milestone: 19.10.0 → 19.10rc1
Changed in mahara:
milestone: 19.10rc1 → 19.10.0
Lisa Seeto (lisaseeto)
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Lisa Seeto (lisaseeto)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10461

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10461
Committed: https://git.mahara.org/mahara/mahara/commit/09b45db272c437cdd209e090e913ba93b1d4d480
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 09b45db272c437cdd209e090e913ba93b1d4d480
Author: Lisa Seeto <email address hidden>
Date: Tue Oct 22 11:22:38 2019 +1300

Bug 1846972: Skin text colour defaults should default to the theme colours

Set up skin colour fields to be able to use the theme default

behatnotneeded

Change-Id: I891f8fbe4907d962535f2e769ad912d073f03f3c
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10482

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10482
Committed: https://git.mahara.org/mahara/mahara/commit/b1ec78765c0cc972ad481e736192c2f9a06c423c
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit b1ec78765c0cc972ad481e736192c2f9a06c423c
Author: Lisa Seeto <email address hidden>
Date: Tue Oct 22 11:22:38 2019 +1300

Bug 1846972: Skin text colour defaults should default to the theme colours

Set up skin colour fields to be able to use the theme default

behatnotneeded

Change-Id: I891f8fbe4907d962535f2e769ad912d073f03f3c
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit 09b45db272c437cdd209e090e913ba93b1d4d480)

Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.