Extra separator at bottom of PL Editor View menu

[Evan Shultz]

The View menu in PL Editor has a separator at the very bottom. Shows up in the nightly version below and also on the source here in LaunchPad. I do not see this in the stable 5.1.4 release.

This is my first patch submission so hopefully I did everything right.

Application: KiCad
Version: (5.99.0-76-g3bd38ec24), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.21.0 (+libidn2/2.1.1) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Ian McInerney (imcinerney)]

This should actually be turned into a conditional compilation for OSX. It was added there because OSX adds some items to the menus on its own. Take a look at menubar_pcb_editor.cpp for an example of what it should look like.

@Jeff, does OSX still add items at the bottom of the view menu after your change to our wxWidgets branch?

[Jeff Young (jeyjey)]

Yes, it still adds “Enter Full Screen”.

> On 2 Oct 2019, at 21:58, Ian McInerney <email address hidden> wrote:
>
> This should actually be turned into a conditional compilation for OSX.
> It was added there because OSX adds some items to the menus on its own.
> Take a look at menubar_pcb_editor.cpp for an example of what it should
> look like.
>
> @Jeff, does OSX still add items at the bottom of the view menu after
> your change to our wxWidgets branch?
>
> --
> You received this bug notification because you are a member of KiCad Bug
> Squad, which is subscribed to KiCad.
> https://bugs.launchpad.net/bugs/1846408
>
> Title:
> Extra separator at bottom of PL Editor View menu
>
> Status in KiCad:
> New
>
> Bug description:
> The View menu in PL Editor has a separator at the very bottom. Shows
> up in the nightly version below and also on the source here in
> LaunchPad. I do not see this in the stable 5.1.4 release.
>
> This is my first patch submission so hopefully I did everything right.
>
> Application: KiCad
> Version: (5.99.0-76-g3bd38ec24), release build
> Libraries:
> wxWidgets 3.0.4
> libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.21.0 (+libidn2/2.1.1) nghttp2/1.34.0
> Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
> Build Info:
> wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
> Boost: 1.68.0
> OpenCASCADE Community Edition: 6.9.1
> Curl: 7.61.1
> Compiler: GCC 8.2.0 with C++ ABI 1013
>
> Build settings:
> KICAD_SCRIPTING=ON
> KICAD_SCRIPTING_MODULES=ON
> KICAD_SCRIPTING_PYTHON3=OFF
> KICAD_SCRIPTING_WXPYTHON=ON
> KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
> KICAD_SCRIPTING_ACTION_MENU=ON
> BUILD_GITHUB_PLUGIN=ON
> KICAD_USE_OCE=ON
> KICAD_USE_OCC=OFF
> KICAD_SPICE=ON
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1846408/+subscriptions

[Evan Shultz (evan-shultz)]

Thanks all for the help. I believe this is what you're looking for. Let me know if there are still issues.

[Evan Shultz (evan-shultz)]

@Ian
@Jeff

I know there's a lot of talk about moving things around so you're busy, but as this is a simple patch would you be able to take a look and let me know if this looks good? Thanks!

[Ian McInerney (imcinerney)]

Sorry about that. It looks good from my end on Linux (I no longer see the separator).

@devs, can someone with a Mac make sure this works and then commit it?

[Jeff Young (jeyjey)]

Looks good on Mac so I pushed it.

Thanks Evan & Ian!