Various theme fixes for 19.10

Bug #1845104 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Evonne Cheung

Bug Description

Smorgasbord of small fixes in the themes to make / keep things more consistent.

Tags: front-end
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10377

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10379

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10383

summary: - Various theme fixes for 19.04
+ Various theme fixes for 19.10
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10388

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10405

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10377
Committed: https://git.mahara.org/mahara/mahara/commit/6510362697015d05c894ff9d971780872598d678
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6510362697015d05c894ff9d971780872598d678
Author: Evonne <email address hidden>
Date: Wed Sep 25 11:07:16 2019 +1200

Bug 1845104 Various theme fixes part 1

Fixing some inconsistencies with user-icon sizes, on profile page,
and recent forum posts, and taking out some redundant styles.

behatnotneeded

Change-Id: Ifef04d165a2257b6c89f007f82b33ef0b37edc3b

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10379
Committed: https://git.mahara.org/mahara/mahara/commit/5c5db7610f0b7913df22e552e7cf9c809869bda6
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5c5db7610f0b7913df22e552e7cf9c809869bda6
Author: Evonne <email address hidden>
Date: Wed Sep 25 15:48:45 2019 +1200

Bug 1845104 Various theme fixes part 2

Fixing metadata inheriting title fonts, plans alignment, comments.

behatnotneeded

Change-Id: Ice9dc3e5b090ad89340bcc6debfd0286d3609395

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10383
Committed: https://git.mahara.org/mahara/mahara/commit/b084c205c563f74727e75c0ef079b23b39072b3e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b084c205c563f74727e75c0ef079b23b39072b3e
Author: Evonne <email address hidden>
Date: Fri Sep 27 10:47:10 2019 +1200

Bug 1845104 Various theme fixes part 3

Fixing buttons and styleguide

behatnotneeded

Change-Id: I661e6350bb14ac4c77e4bf63777b346810ce5c65

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10388
Committed: https://git.mahara.org/mahara/mahara/commit/c0cc88deec01a158fea0744689a0369e29390d92
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c0cc88deec01a158fea0744689a0369e29390d92
Author: Evonne <email address hidden>
Date: Tue Oct 1 15:50:11 2019 +1300

Bug 1845104 Various theme fixes part 4

Fixing plans blocktype markup, inbox blocktype redundant classes,
alignment of add blocks button, modal thumbnail not floating right,
resume attachment inconsistencies (to be continued)

behatnotneeded

Change-Id: Ic7c0cc5498dbd3f95f140581cc71b175e944a0d9

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10405
Committed: https://git.mahara.org/mahara/mahara/commit/e8475a336225eb6c6f5e3ec2806425c4234f9604
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e8475a336225eb6c6f5e3ec2806425c4234f9604
Author: Evonne <email address hidden>
Date: Fri Oct 4 15:38:21 2019 +1300

Bug 1845104 Various theme fixes part 5

Changing attached files to not a heading and getting unified
markup and styling of attachments and downloads across journals,
resumes and files.

behatnotneeded

Change-Id: I66ae6a41068273af3780577bad5acf6f812d08d2

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10420

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10422

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10422
Committed: https://git.mahara.org/mahara/mahara/commit/cfc151e0877fe917b53b937ebcda113edf4041db
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit cfc151e0877fe917b53b937ebcda113edf4041db
Author: Evonne <email address hidden>
Date: Tue Oct 8 13:24:11 2019 +1300

Bug 1845104 Various small style bugs

- Chervons missing in inbox block, conflicting with text-small.
- People list h4 wrapping portfolio list, moving it out.
- dashboard editbuttons placement dependent on h1/h2 above, put in
better conditions so it doesn't need it at all.
- Plans chervon too far in, moved it out as no longer has details.

behatnotneeded

Change-Id: I50e60e2fb2c8be2370856823497a1b9099d1c28f

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10420
Committed: https://git.mahara.org/mahara/mahara/commit/178bb243e436eb2a87435b17aa13882aaccc5dcb
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 178bb243e436eb2a87435b17aa13882aaccc5dcb
Author: Evonne <email address hidden>
Date: Tue Oct 8 12:28:31 2019 +1300

Bug 1845104 Page and collection horizontal scroll

Took out overflow-x: auto; in .view-container, can't see it
breaking anything else so might be redundant legency css. Pages
and Collections should no longer have an orange horizontal scroll
under it.

behatnotneeded

Change-Id: I52f0a77a403cdc72163b4d7a60f19f99b28c0486

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10423

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10423
Committed: https://git.mahara.org/mahara/mahara/commit/139991ae6a58d40b495e20ad0b40f7b7b12d7892
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 139991ae6a58d40b495e20ad0b40f7b7b12d7892
Author: Evonne <email address hidden>
Date: Tue Oct 8 15:54:26 2019 +1300

Bug 1845104 More small style bugs

- Plan block in editor has chervons hidden under buttons.
- Removing list-group-item first-child top border only when list
appears directly below heading and not other cases, this gets
repeated for in editor.
- Tagged journal in full block should be flushed.
- PDF has slight gap under header just like images/media.
- PDF configure form has alert message with better spacing
- Brand icons weren't working, like social media.

behatnotneeded

Change-Id: I7d373034de8188be5e8535d488468ef371516a22

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10430

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10438

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10446

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10451

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10430
Committed: https://git.mahara.org/mahara/mahara/commit/b67ca83f57342427800d67d846753a1c686fec2c
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b67ca83f57342427800d67d846753a1c686fec2c
Author: Evonne <email address hidden>
Date: Wed Oct 9 11:08:30 2019 +1300

Bug 1845104 Default theme bugs

- removing some redundant styles in default
- inbox message was too long for font to display in single line
- putting some styles back into raw instead
- search form in header wasn't fitting on single line on small device

behatnotneeded

Change-Id: Id556abbf0adecbae89378b91ee3164f89fe55285

Changed in mahara:
status: Fix Committed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10455

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10455
Committed: https://git.mahara.org/mahara/mahara/commit/fe811e9c35fd7ebeaf5eb068556605106f6df2b6
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit fe811e9c35fd7ebeaf5eb068556605106f6df2b6
Author: Evonne <email address hidden>
Date: Wed Oct 9 11:08:30 2019 +1300

Bug 1845104 Default theme bugs

- removing some redundant styles in default
- inbox message was too long for font to display in single line
- putting some styles back into raw instead
- search form in header wasn't fitting on single line on small device

behatnotneeded

Change-Id: Id556abbf0adecbae89378b91ee3164f89fe55285
(cherry picked from commit b67ca83f57342427800d67d846753a1c686fec2c)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10446
Committed: https://git.mahara.org/mahara/mahara/commit/ce78dc845971e7b325f2e82531846296402c1c9d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ce78dc845971e7b325f2e82531846296402c1c9d
Author: Evonne <email address hidden>
Date: Tue Oct 15 13:57:54 2019 +1300

Bug 1845104 Ocean theme changes

- removed redundant styles
- take custom font out of list-group titles for better readability
- put necessary changes back to raw
- put styles in custom.scss into right files

behatnotneeded

Change-Id: I3b43b631460b2557c07211e307648ef3e95fd94a

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10451
Committed: https://git.mahara.org/mahara/mahara/commit/01f29d8c1c5aea7226982f108f9b2f22786457fa
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 01f29d8c1c5aea7226982f108f9b2f22786457fa
Author: Evonne <email address hidden>
Date: Fri Oct 18 15:29:05 2019 +1300

Bug 1845104 Primary School theme changes

- remove redundant styles
- put necessary changes back to raw
- recalculate card-header colour backgrounds for gridstack
- realigning gridstack margins with page margins
- small tidying in raw

behatnotneeded

Change-Id: I21cbfee31344794560d17d121d306f8ba5ae6dc0

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10438
Committed: https://git.mahara.org/mahara/mahara/commit/1d1bb649aa10c043f6a684ffa5ed712d95498e70
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1d1bb649aa10c043f6a684ffa5ed712d95498e70
Author: Evonne <email address hidden>
Date: Fri Oct 11 15:22:38 2019 +1300

Bug 1845104 Modern theme changes

- removed redundant styles
- reconvert files to make macros work on windows (has to do with woff)
- put necessary changes back into raw
- put in OFL file for font Raleway

behatnotneeded

Change-Id: If1a3eb4bfba86ec18f3f0e38104b79e6642048d0

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10476

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10476
Committed: https://git.mahara.org/mahara/mahara/commit/b86ba75d91aa7053501f60e306ad55edd2c1cda0
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit b86ba75d91aa7053501f60e306ad55edd2c1cda0
Author: Evonne <email address hidden>
Date: Tue Oct 15 13:57:54 2019 +1300

Bug 1845104 Ocean theme changes

- removed redundant styles
- take custom font out of list-group titles for better readability
- put necessary changes back to raw
- put styles in custom.scss into right files

behatnotneeded

Change-Id: I3b43b631460b2557c07211e307648ef3e95fd94a
(cherry picked from commit ce78dc845971e7b325f2e82531846296402c1c9d)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10479

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10479
Committed: https://git.mahara.org/mahara/mahara/commit/1d00435f388edb535d8e90cb3a94daa7cb7e2346
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit 1d00435f388edb535d8e90cb3a94daa7cb7e2346
Author: Evonne <email address hidden>
Date: Fri Oct 18 15:29:05 2019 +1300

Bug 1845104 Primary School theme changes

- remove redundant styles
- put necessary changes back to raw
- recalculate card-header colour backgrounds for gridstack
- realigning gridstack margins with page margins
- small tidying in raw

behatnotneeded

Change-Id: I21cbfee31344794560d17d121d306f8ba5ae6dc0
(cherry picked from commit 01f29d8c1c5aea7226982f108f9b2f22786457fa)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10481

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10481
Committed: https://git.mahara.org/mahara/mahara/commit/c0d701ed53043ae8e1e644d0e35014901863fad5
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit c0d701ed53043ae8e1e644d0e35014901863fad5
Author: Evonne <email address hidden>
Date: Fri Oct 11 15:22:38 2019 +1300

Bug 1845104 Modern theme changes

- removed redundant styles
- reconvert files to make macros work on windows (has to do with woff)
- put necessary changes back into raw
- put in OFL file for font Raleway

behatnotneeded

Change-Id: If1a3eb4bfba86ec18f3f0e38104b79e6642048d0

Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10568

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10568
Committed: https://git.mahara.org/mahara/mahara/commit/ba47225e6ad75fc7c1c80f83db2889131dc39e68
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ba47225e6ad75fc7c1c80f83db2889131dc39e68
Author: Evonne <email address hidden>
Date: Wed Nov 6 15:34:01 2019 +1300

Bug 1845104 various theme fixes

- cards-quarter in responsive
- list-group-item in entire resume

behatnotneeded

Change-Id: Iddc6730252a26ce7f8c950ea0ba01a56395e590b

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.