Turn font specimen page into a modal

[Rangi Daymond]

TITLE: Old Mahara logo displayed on Fonts specimen pages

BUG SUMMARY: Old Mahara logo displayed on Configure site --> Fonts 'View font specimen' detail page

ENVIRONMENT: Master
PATCHSET: git fetch https://reviews.mahara.org/mahara refs/changes/12/10312/8 && git checkout FETCH_HEAD
BROWSER: Firefox

PRECONDITION/S: n/a

TEST STEPS:
1) Log in using the Mahara Admin user
2) Navigate to Configure site --> Fonts, 'All fonts' will be displayed (including the Theme fonts)
3) On one or more of the displayed font rows, select the 'View font specimen' link (second link top right)

Expected result (updated after comment 2): Show the correct Mahara page element, including header, footer, and heading, no custom Mahara logo.
Actual result: see attached screen shot - the old Mahara logo is displayed.

[Kristina Hoeppner (kris-hoeppner)]

This entire page actually doesn't have the proper Mahara header. Instead of including a custom Mahara logo, it will be better to make it a proper page to use the normal header and footer and page heading.

Ideally, the page heading behaves like the page heading for an institution when on the "Settings" page: "Name of institution | Institution settings". So for the fonts specimen page that would be:

Name of the font | Fonts

[Kristina Hoeppner (kris-hoeppner)]

It is a problem in all supported versions, just found on the patch. We'll only fix in master though because it's not an issue that prevents Mahara from functioning, but is more of a clean-up.

[Kristina Hoeppner (kris-hoeppner)]

Robert said it was actually most likely a pop-up at some stage. So we should put the modal (coming in from top) back in place. That way, we are also not leaving the page.

Still, we do not need the logo anymore.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10376

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10376
Committed: https://git.mahara.org/mahara/mahara/commit/c0889d626edf1af6806a139a980a3774c1f88f3a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c0889d626edf1af6806a139a980a3774c1f88f3a
Author: Robert Lyon <email address hidden>
Date: Wed Sep 25 09:17:28 2019 +1200

Bug 1844953: Make the font specimens appear in modal

Rather than a new page

behatnotneeded

Change-Id: If81c1b343b1d32e291ca90e036082009c2d33a4f
Signed-off-by: Robert Lyon <email address hidden>