fwupd ftbfs in eoan

[Matthias Klose]

all archs,
https://launchpadlibrarian.net/441262811/buildlog_ubuntu-eoan-amd64.fwupd_1.2.10-1ubuntu1_BUILDING.txt.gz

Ok: 13
Expected Fail: 0
Fail: 2
Unexpected Pass: 0
Skipped: 0
Timeout: 0
dh_auto_test: cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 MESON_TESTTHREADS=4 ninja test returned exit code 1
make[1]: *** [debian/rules:97: override_dh_auto_test] Error 255
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:31: build] Error 2

[Mario Limonciello (superm1)]

I would guess this needs to be backported.

https://github.com/fwupd/fwupd/commit/b4627629cdaadd1a75d7c650b7c5973fcd18dfb0

On Mon, Sep 16, 2019, 04:15 Brian Murray <email address hidden> wrote:

> ** Also affects: fwupd (Ubuntu Eoan)
> Importance: High
> Status: Confirmed
>
> ** Tags removed: rls-ee-incoming
>
> --
> You received this bug notification because you are subscribed to fwupd
> in Ubuntu.
> Matching subscriptions: fwupd bugs
> https://bugs.launchpad.net/bugs/1843735
>
> Title:
> fwupd ftbfs in eoan
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1843735/+subscriptions
>

[Sebastien Bacher (seb128)]

Updated log url
https://launchpadlibrarian.net/443324062/buildlog_ubuntu-eoan-amd64.fwupd_1.2.10-1ubuntu1_BUILDING.txt.gz

Mario, the patch looks like it might fix one test error but there is also that one

'Bail out! Fwupd:ERROR:../libfwupd/fwupd-self-test.c:517:fwupd_common_machine_hash_func: assertion failed (error == NULL): The machine-id is present but unset (FwupdError, 5)'

[Mario Limonciello (superm1)]

Did something change on some of the buildds to have a machine id but make it empty? The self test code skips machine ID tests if it's not present: https://github.com/fwupd/fwupd/blob/master/libfwupd/fwupd-self-test.c#L532

[Mario Limonciello (superm1)]

Anyway, if that's the new environment to deal with, I'll open a PR upstream to skip the test in that case too. https://github.com/fwupd/fwupd/pull/1398

[Mario Limonciello (superm1)]

Before I realized there was a second problem (since my local test build worked) I uploaded 1.2.10-1ubuntu2. I fixed the second problem in a second upload, same version with the expectation an archive administrator would reject the first and accept the second.

Both are in the unapproved queue, so hopefully can be reviewed before eoan final.