Correct submission confirmation email lang string

Bug #1843691 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Kristina Hoeppner

Bug Description

New 19.10 functionality.

There was an extra indentation in the email confirming that you've submitted a portfolio successfully to a group. I corrected the spacing.

Before:

----------

This is to confirm that you submitted the collection "Portfolio 4" successfully
to the group "L&D" at 12-09-2019, 19:54.
                      If you have any questions about this submission, please
contact the group administrator.
----------

After:

----------
This is to confirm that you submitted the collection "Portfolio 4" successfully
to the group "L&D" at 12-09-2019, 19:54.

If you have any questions about this submission, please contact the group administrator.
-----------

To replicate:

Precondition: Set up a group that allows submissions and have Person A in there besides the group admin.

1. Person A creates a page.
2. Person A submits the page to the group.
Expected result: Person A receives a notification in their Mahara inbox and via email if set up (default) that does not have a large indentation for the second sentence and where there is an empty line between the first and second sentence.

Actual result: See "Before" scenario.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10339

Revision history for this message
Steven (stevens-q) wrote :

Commit hash: 48caa852dca3e950521245bc476302558de84884
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) The following user exist
      a) Site admin and is admin for group 11
      b) User5 (no roles) and is a member of group 11
2) Group 11 exists as follows
      a) Controlled = Yes
      b) Allow submissions = Yes
      c) Allow archiving of submissions = No
      d) Publicly viewable group = Yes
      e) Hide group = No
      f) Auto-add users = No

TEST STEPS:
------------------------
1) Log in as User5
2) User5 create a portfolio page and submit the page to a group via viewing the displayed page
3) Verify Person A receives a notification in their Mahara inbox and via email if set up (default) that does not have a large indentation for the second sentence and where there is an empty line between the first and second sentence. ✔
      a) The following text should be displayed ✔

This is to confirm that you submitted the collection "Portfolio 4" successfully to the group "L&D" at 12-09-2019, 19:54.

If you have any questions about this submission, please contact the group administrator.

Catalyst QA Approved ✔

Revision history for this message
Steven (stevens-q) wrote :

In addition to the last comment. A check was made to verify the subject wording is correct for both the notification through the site and emails that are sent to the User.

 Subject wording is as follows:

      Subject: Your submission of your collection was successful
      Subject: Your submission of your page was successful

- No issues were found

Catalyst QA Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10339
Committed: https://git.mahara.org/mahara/mahara/commit/81733da12639cca1b76d79405a3837dd13e88f21
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 81733da12639cca1b76d79405a3837dd13e88f21
Author: Kristina D.C. Hoeppner <email address hidden>
Date: Thu Sep 12 21:36:53 2019 +1200

Bug 1843691: Correct spacing in submission report notification

Fixed the spacing in the notification to make it
more consistent with other mails.

Also fixed the subject where only "page" or "collection" was shown and
thus we don't need the quotation marks.

behatnotneeded

Change-Id: I5403c70dab8fed11718071573c1bc525ada4a768

Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.