Open and close blocks modal causes error when block is placed on page

[Steven]

BUG SUMMARY: click the + icon to add a block and then click away from modal to close the modal - when a user does add a block to the page an error is displayed
**************************************************

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) N/A

TEST STEPS:
------------------------
1) Log in as any user
2) Create a portfolio page
3) Double click the + icon to add a block
4) Click the + Icon again and add any block type

EXPECTED RESULT: when clicking the + icon and then clicking it again or any where outside the modal should close the modal. The user can then open the modal and add a block to the page

ACTUAL RESULT: click the + icon to add a block and then click away from modal to close the modal - when a user does add a block to the page an error is displayed

See attached file for error message

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10321

[Rangi Daymond (rangid)]

Gerrit/Patchset: https://reviews.mahara.org/#/c/10321/ e29cbe06f5a1aa9680de3701b1f6d121de7bef19
Browser tested: Firefox and Chrome
Theme used: Raw

*PRECONDITIONS: N/A defect reproduced as above
---------------

*TEST STEPS: as described above, repeated in both browsers
------------
1. Logged in as non-administrative user Bob User2
2. Created a portfolio page
3. Double+ clicked the + icon to add a block
4. Clicked the + icon again and added a text block

EXPECTED RESULT: when clicking the + icon and then clicking it again or any where outside the modal should close the modal. The user can then open the modal and add a block to the page.
ACTUAL RESULT: as expected - each click either opens or closes the modal. Once details added the block saves successfully without error.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10321
Committed: https://git.mahara.org/mahara/mahara/commit/e29cbe06f5a1aa9680de3701b1f6d121de7bef19
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e29cbe06f5a1aa9680de3701b1f6d121de7bef19
Author: Robert Lyon <email address hidden>
Date: Tue Sep 10 11:43:50 2019 +1200

Bug 1843351: Stop the multi-click on add block causing multi save

So that we only try and save the new block one time

behatnotneeded

Change-Id: I6dd1fbe0bcaf98c37db7ee601198efa108867970
Signed-off-by: Robert Lyon <email address hidden>