Allow theme fonts to be listed on the admin -> configure site -> fonts page

Bug #1843202 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Unassigned

Bug Description

So that they are viewable there and also be able to be used in skins

Robert Lyon (robertl-9)
Changed in mahara:
importance: Undecided → Wishlist
milestone: none → 19.10.0
status: New → In Progress
Revision history for this message
Rangi Daymond (rangid) wrote :
Download full text (5.4 KiB)

Gerrit/Patchset: https://reviews.mahara.org/mahara refs/changes/12/10312/8
Mahara Environment: my laptop Mahara environment http://mahara.rdaymond.wgtn.cat-it.co.nz/
Browser/s tested: Firefox and Chrome
Theme used: Default

**TEST OBJECTIVE: Verify that the theme fonts are accessible via admin -> configure site ->
***************** fonts page and that they may be selected to be used in skins (institution versus user created).
Note: to confirm what themes and fonts should be available navigate to the link below (there are 6 theme subfolders; custom, default, modern, ocean, primaryschool and raw).
URL to check: https://git.mahara.org/mahara/mahara/tree/master/htdocs/theme/
Check each of the sub-folders to see their font/s - the results are 5 in total;
- custom n/a, default none, modern 1, ocean 1, primaryschool 1 and raw 2 (1 for headings & 1 for text other 2 'fonts' in here are related to icons)

**PRECONDITIONS:
****************
1) Tester has access to the following user types; Mahara Admin, non-Admin user

**TEST STEPS:
*************

Scenario 1: Verify that the theme fonts are present and accessible by the admin user.
------------------
Step 1.1) Logged in Admin user navigates to Configure site --> Fonts --> select the 'Show' drop
down.
Expected result 1.1: The default option 'All fonts' is loaded and each font is
displayed (one 'row' each in font name order) in Preview mode as per the default Text and Size
values. When the 'Show' drop down is opened, a new fourth 'Theme fonts' option is present
(follows the 3rd 'Google fonts' option).
Note: initially there were only the 5 Theme fonts present
Actual result 1.1) as expected ✓

Step 1.2) User varies the selected Text, Size and Show options selected then selects the Preview button
Expected result 1.2: the left hand font name and sample Text display adjusts accordingly.
Actual result 1.2: as expected ✓

Step 1.3) User selects the 'Theme fonts' Show option
Expected result 1.3: The following five fonts are displayed (in alphabetic Theme name order) in Preview mode:
ER1.3.1 theme name Modern, font name Raleway
ER1.3.2 theme name Ocean, font name Osvaldo
ER1.3.3 theme name Primary School, font name Shadows into Light Two
ER1.3.4 & 5 theme name Raw, first font name Roboto slab, second font name Open Sans
Notes: there are five themes, the first 'Default' has no font/s
Actual result 1.3: as expected ✓ (see attachment)

Step 1.4) User adds 3 google fonts using the 'Install Google font(s) button
Expected result 1.4: The three new google fonts are correctly displayed with the existing five
Theme fonts via the 1.4.1 Show 'All fonts' (8 displayed in font name order),
via the 1.4.2 Show 'Google fonts' (3 displayed in font name order) &
1.4.3 Show 'Theme fonts' (5 displayed)
Actual result 1.4: each as expected ✓

Scenario 2: Verify that the theme fonts are present for selection when an Admin user chooses
------------------ to create a skin.
Step 2.1) Logged in Admin user navigates to Configure site --> Skins & selects to 'Create
skin'.
Step 2.2) The Create skin screen tabs are available (default tab General selected), select the
'Fonts and colours' tab option.
Step 2.3) Select the 'Heading font' drop...

Read more...

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10311
Committed: https://git.mahara.org/mahara/mahara/commit/9d5d3601598889dbeec7551d2ac375c5a1350890
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9d5d3601598889dbeec7551d2ac375c5a1350890
Author: Robert Lyon <email address hidden>
Date: Fri Sep 6 17:50:16 2019 +1200

Bug 1843202: Allow the local installed .woff font to try inbuilt fonts

before trying the supplied one

- see https://developer.mozilla.org/en-US/docs/Web/CSS/@font-face

Change-Id: I92ad19ba44bb091a7b5349cafca3affe83923ab9
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10312
Committed: https://git.mahara.org/mahara/mahara/commit/d61b94873d76cc41a3679eb28b74f5919cf30c45
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit d61b94873d76cc41a3679eb28b74f5919cf30c45
Author: Robert Lyon <email address hidden>
Date: Sat Sep 7 17:01:11 2019 +1200

Bug 1843202: Allow theme fonts to be included in skin_fonts table

So that they can be
- used in skins
- viewed on the Admin -> Config -> Fonts page

behatnotneeded

Change-Id: I49aff91a7f56a003adbc9f3513aa9a094a3069e4
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
tags: added: nominatedfeature
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.