Mahara

Tidy up some places where we call pieform() after smarty_core()

Bug #1841988 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
Mahara 19.10.0

Bug Description

If we call pieform() after smarty_core() it generates an error:

Pieform element XXX wants to add headdata to the page, but it's too late. Build your form before generating the page.

So will tidy up the existing places where this is still the case

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 19.10.0
status: New → In Progress
importance: Undecided → High
importance: High → Medium
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10279

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10279
Committed: https://git.mahara.org/mahara/mahara/commit/22e4a2dd656f77425645ecc3a357b705678ee825
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 22e4a2dd656f77425645ecc3a357b705678ee825
Author: Robert Lyon <email address hidden>
Date: Fri Aug 30 08:08:29 2019 +1200

Bug 1841988: Making sure pieform is generated before smarty_core() call

There are a few places where this was not being done in correct order

Also fixed up the add admins / staff pages so that submitting nothing
gives an error

behatnotneeded

Change-Id: Ib60a3a4ffce0e73b38c42badc57cfc6fe6db372c
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.