pcbnew: MacOS Shortcut Clash between Place Zone and Redo

[Andrey Kuznetsov]

On MacOS there's a shortcut clash between Place Zone and Redo. Both utilize CMD+SHIFT+Z.

Application: kicad
Version: (5.1.2-1)-1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.5 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.6.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 9.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

@Andrey,

The place zone hotkey has changed to Alt-Z. Open Preferences > HotKeys and reset the Zone Hotkey to default.

[Andrey Kuznetsov (kandrey89)]

That is the default, did it change after the version I'm using?

[Jeff Young (jeyjey)]

I didn't notice you were on 5.1.2. This wasn't fixed until 6.0.

[Andrey Kuznetsov (kandrey89)]

Can this be pushed into v5.1.5? The Redo command is getting clobbered, and since it'll be another year for v6 to come out...

[Seth Hillbrand (sethh)]

@Andrey- Are you unable to change the hotkey for place zone?

[Andrey Kuznetsov (kandrey89)]

That's not the point Seth. It's unprofessional to ship a software that by
default has a broken redo shortcut, kicad isn't only used by developers and
testers, it's for people learning pcb design for the first time. White it
seems trivial to just go and change the hotkey assignment, a newbie would
even understand why the redo isn't working.

On Tue, Aug 6, 2019 at 5:40 AM Seth Hillbrand <
<email address hidden>> wrote:

> @Andrey- Are you unable to change the hotkey for place zone?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1839049
>
> Title:
> pcbnew: MacOS Shortcut Clash between Place Zone and Redo
>
> Status in KiCad:
> Fix Committed
>
> Bug description:
> On MacOS there's a shortcut clash between Place Zone and Redo. Both
> utilize CMD+SHIFT+Z.
>
> Application: kicad
> Version: (5.1.2-1)-1, release build
> Libraries:
> wxWidgets 3.0.4
> libcurl/7.54.0 LibreSSL/2.6.5 zlib/1.2.11 nghttp2/1.24.1
> Platform: Mac OS X (Darwin 18.6.0 x86_64), 64 bit, Little endian, wxMac
> Build Info:
> wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
> Boost: 1.69.0
> OpenCASCADE Community Edition: 6.9.1
> Curl: 7.54.0
> Compiler: Clang 9.0.0 with C++ ABI 1002
>
> Build settings:
> USE_WX_GRAPHICS_CONTEXT=ON
> USE_WX_OVERLAY=ON
> KICAD_SCRIPTING=ON
> KICAD_SCRIPTING_MODULES=ON
> KICAD_SCRIPTING_PYTHON3=OFF
> KICAD_SCRIPTING_WXPYTHON=ON
> KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
> KICAD_SCRIPTING_ACTION_MENU=ON
> BUILD_GITHUB_PLUGIN=ON
> KICAD_USE_OCE=ON
> KICAD_USE_OCC=OFF
> KICAD_SPICE=ON
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1839049/+subscriptions
>
--
Remember The Past, Live The Present, Change The Future
Those who look only to the past or the present are certain to miss the
future [JFK]

<email address hidden>
Live Long and Prosper,
Andrey

[Jeff Young (jeyjey)]

@Andrey, the 6.0 fix can't be pushed. The hotkey architecture was completely rewritten around ACTIONs.

We could do a separate fix just for the colliding hotkeys. Trouble is that any fix has some non-zero risk of introducing another bug. Personally my rule would be to only back-port high and critical bugs, but the Kicad team's practice is more lenient.

[Andrey Kuznetsov (kandrey89)]

OK, I understand about the architecture, however for this case, all that's
needed is a hotkey remapping for default config. That should have 0 risk
provided the person doing it checks it doesn't collide with something else.
Thanks

On Tue, Aug 6, 2019 at 9:30 AM Jeff Young <email address hidden>
wrote:

> @Andrey, the 6.0 fix can't be pushed. The hotkey architecture was
> completely rewritten around ACTIONs.
>
> We could do a separate fix just for the colliding hotkeys. Trouble is
> that any fix has some non-zero risk of introducing another bug.
> Personally my rule would be to only back-port high and critical bugs,
> but the Kicad team's practice is more lenient.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1839049
>
> Title:
> pcbnew: MacOS Shortcut Clash between Place Zone and Redo
>
> Status in KiCad:
> Fix Committed
>
> Bug description:
> On MacOS there's a shortcut clash between Place Zone and Redo. Both
> utilize CMD+SHIFT+Z.
>
> Application: kicad
> Version: (5.1.2-1)-1, release build
> Libraries:
> wxWidgets 3.0.4
> libcurl/7.54.0 LibreSSL/2.6.5 zlib/1.2.11 nghttp2/1.24.1
> Platform: Mac OS X (Darwin 18.6.0 x86_64), 64 bit, Little endian, wxMac
> Build Info:
> wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
> Boost: 1.69.0
> OpenCASCADE Community Edition: 6.9.1
> Curl: 7.54.0
> Compiler: Clang 9.0.0 with C++ ABI 1002
>
> Build settings:
> USE_WX_GRAPHICS_CONTEXT=ON
> USE_WX_OVERLAY=ON
> KICAD_SCRIPTING=ON
> KICAD_SCRIPTING_MODULES=ON
> KICAD_SCRIPTING_PYTHON3=OFF
> KICAD_SCRIPTING_WXPYTHON=ON
> KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
> KICAD_SCRIPTING_ACTION_MENU=ON
> BUILD_GITHUB_PLUGIN=ON
> KICAD_USE_OCE=ON
> KICAD_USE_OCC=OFF
> KICAD_SPICE=ON
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1839049/+subscriptions
>
--
Remember The Past, Live The Present, Change The Future
Those who look only to the past or the present are certain to miss the
future [JFK]

<email address hidden>
Live Long and Prosper,
Andrey

[Wayne Stambaugh (stambaughw)]

Changing the hotkey is not a sufficient fix. We would need to add a method for detecting duplicate key assignments on start up because when we assign a new hotkey for a new feature, it could conflict with a key assignment set by the user. The other option is to reset all of the keys to the default settings every time we add a new key assignment. I'm guessing the latter isn't going to go over very well. It's a fair amount of work for a small net gain but I can understand the frustration.

[Andrey Kuznetsov (kandrey89)]

I see what you mean re:existing hotkey conflict.
I was proposing just a simple reassignment for the default value and not
worry about what the user might have. I was under the impression user
hotkeys are not updated when installing a new version.
Thus the fix would only be for new people installing kicad for the first
time and they are the ones who'd benefit the most from this fix.

On Tue, Aug 6, 2019 at 10:50 AM Wayne Stambaugh <email address hidden>
wrote:

> Changing the hotkey is not a sufficient fix. We would need to add a
> method for detecting duplicate key assignments on start up because when
> we assign a new hotkey for a new feature, it could conflict with a key
> assignment set by the user. The other option is to reset all of the
> keys to the default settings every time we add a new key assignment.
> I'm guessing the latter isn't going to go over very well. It's a fair
> amount of work for a small net gain but I can understand the
> frustration.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1839049
>
> Title:
> pcbnew: MacOS Shortcut Clash between Place Zone and Redo
>
> Status in KiCad:
> Fix Committed
>
> Bug description:
> On MacOS there's a shortcut clash between Place Zone and Redo. Both
> utilize CMD+SHIFT+Z.
>
> Application: kicad
> Version: (5.1.2-1)-1, release build
> Libraries:
> wxWidgets 3.0.4
> libcurl/7.54.0 LibreSSL/2.6.5 zlib/1.2.11 nghttp2/1.24.1
> Platform: Mac OS X (Darwin 18.6.0 x86_64), 64 bit, Little endian, wxMac
> Build Info:
> wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
> Boost: 1.69.0
> OpenCASCADE Community Edition: 6.9.1
> Curl: 7.54.0
> Compiler: Clang 9.0.0 with C++ ABI 1002
>
> Build settings:
> USE_WX_GRAPHICS_CONTEXT=ON
> USE_WX_OVERLAY=ON
> KICAD_SCRIPTING=ON
> KICAD_SCRIPTING_MODULES=ON
> KICAD_SCRIPTING_PYTHON3=OFF
> KICAD_SCRIPTING_WXPYTHON=ON
> KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
> KICAD_SCRIPTING_ACTION_MENU=ON
> BUILD_GITHUB_PLUGIN=ON
> KICAD_USE_OCE=ON
> KICAD_USE_OCC=OFF
> KICAD_SPICE=ON
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1839049/+subscriptions
>

--
Remember The Past, Live The Present, Change The Future
Those who look only to the past or the present are certain to miss the
future [JFK]

<email address hidden>
Live Long and Prosper,
Andrey