Adjust find_by_instanceid_username() function to allow check remote then fallback to usr table

Bug #1839032 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Unassigned

Bug Description

Currently the find_by_instanceid_username() function either only checks the remote user table (auth_remote_user) or it checks the user table (usr)

It would be more useful if it could do the following:

When $remoteuser flag is set:

- Check remote user table and return user if a match found
- But if no match found then fall back to check user table

When $remoteuser flag is not set:

- Just check user table

Robert Lyon (robertl-9)
Changed in mahara:
importance: Undecided → Wishlist
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10243

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10243
Committed: https://git.mahara.org/mahara/mahara/commit/977986426db4093955a9a60307a37145a4227325
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 977986426db4093955a9a60307a37145a4227325
Author: Robert Lyon <email address hidden>
Date: Tue Aug 6 09:14:47 2019 +1200

Bug 1839032: Adjust $user->find_by_instanceid_username()

Currently it checks either
- remote user table
or
- the user table

Allow it to check either
- remote user table
-- then user table if not found in remote user table
or
- the user table

Change-Id: Iaa5a59ea056a2a4ce40df324b0f084d0fcd941d8
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
milestone: none → 19.10.0
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.