dkms script is missing function find_module
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
DKMS |
Fix Released
|
Critical
|
Alex Tu | ||
dkms (Ubuntu) |
Fix Released
|
Critical
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned | ||
Disco |
Fix Released
|
Undecided
|
Unassigned | ||
Eoan |
Fix Released
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Critical
|
Unassigned |
Bug Description
update for SRU process:
[Impact]
1. dkms script is missing function find_module
2. priority of OBSOLETE_BY should higher than "force". #89 https:/
[Test case]
install the dkms which already patched (also can be found in my ppa[1])
1. install a dkms which for a kernel module system already installed.
e.g. ath10k of my testing ppa : [1]
1.1. the dkms can be installed well.
2. install a dkms which has OBSOLETE_BY and FORCE
e.g.ath10k of my testing ppa : [1] (source code in [2])
- the target dkms defined OBSOLETE_BY and FORCE
- user install dkms on a system which installed kernel version less than OBSOLETE_BY and another kernel higher than OBSOLETE_BY
- the dkms can be installed well.
[Regression potential]
medium as it touched the version sanity. This change correct the code logic and land one more change from upstream as well.
The logic has been verified by #5 and me.
-------
Building a kernel module using dkms in Linux Mint 19.1 shows the following error:
Running module version sanity check.
/usr/sbin/dkms: Zeile 784: find_module: Befehl nicht gefunden
modinfo: ERROR: missing module or filename.
Checking the file the function is indeed missing and another user confirmed, that it was removed at some point: https:/
Possible solution: Readd
find_module()
{
# tree = $1
# module = $2
find "$1" -name "$2$module_
return $?
}
as found in https:/
Changed in dkms (Ubuntu): | |
importance: | Undecided → Critical |
tags: | added: regression-update |
Changed in dkms: | |
importance: | Undecided → Critical |
Changed in dkms: | |
status: | In Progress → Fix Released |
tags: | removed: verification-needed |
tags: | added: rls-ff-incoming |
Changed in dkms (Ubuntu Eoan): | |
status: | New → Triaged |
Changed in dkms (Ubuntu Focal): | |
status: | Confirmed → Triaged |
Changed in dkms: | |
status: | Confirmed → Fix Released |
tags: | removed: verification-needed |
Bug was introduced in by 2.3-3ubuntu9.4 the following commit: https:/ /git.launchpad. net/ubuntu/ +source/ dkms/commit/ ?id=4cfc905dc60 5628eb6d3ceddb2 1fb12cac9543d5:
Relevant diff:
- read -a kernels_module < <(find $lib_tree -name ${4}$module_suffix)
+ read -a kernels_module < <(find_module "$lib_tree" "${4}")
Reverting this should fix this bug