Angular catalog: using replace barcode on multiple items actually just does the same item over and over again
Bug #1837067 reported by
Jane Sandberg
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned |
Bug Description
There is a small race condition in the replace barcode code. As a result, you can recreate the following error:
1) In the experimental Angular staff catalog, open up a bib record.
2) Open the Holdings View tab.
3) Select several items.
4) Use the Actions for Selected Rows menu to Replace Barcodes.
5) Change the first barcode to something recognizable. Click the Replace Barcode button.
6) Note that the dialog opens again to ask you to replace the barcode you just added.
Branch forthcoming.
Changed in evergreen: | |
status: | New → Confirmed |
assignee: | nobody → Bill Erickson (berick) |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Branch here: user/sandbergja /lp1837067_ race_condition_ in_replace_ barcode /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ sandbergja/ lp1837067_ race_condition_ in_replace_ barcode
Here's a link: https:/
Testing instructions and other details from the commit message:
To test:
1) In the experimental Angular staff catalog, open up a bib record.
2) Open the Holdings View tab.
3) Select several items.
4) Use the Actions for Selected Rows menu to Replace Barcodes
5) Change the first barcode to something recognizable. Click the
Replace Barcode button.
6) Note that the dialog opens again to ask you to replace the
barcode you just added.
7) Apply this patch.
8) Repeat steps 1-5.
9) Note that the dialog opens again to ask you to replace the next
barcode.
Also removes some unused imports, and consolidates two RxJS pipes that were next to one another.