Tag cloud invalid font size
Bug #1836017 reported by
Zvonko Martinović
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Robert Lyon |
Bug Description
Font size in Tag cloud side block is not generated right. Font size is generated in lin/mahara.php, line 3985 (function get_my_tags). Code to generate tag is:
$t->size = sprintf("%0.1f", $minsize + ($maxsize - $minsize) * $weight);
Specifier f in sprintf function is local aware so in languages that use comma as decimal separator (like Croatian language) it will generate invalid value for HTML font size. Fix is simple, just use non-locale aware specifier:
$t->size = sprintf("%0.1F", $minsize + ($maxsize - $minsize) * $weight);
This will always generate decimal number with period as a decimal separator.
Changed in mahara: | |
status: | New → Triaged |
importance: | Undecided → High |
milestone: | none → 19.10.0 |
importance: | High → Medium |
Changed in mahara: | |
status: | Triaged → In Progress |
assignee: | nobody → Robert Lyon (robertl-9) |
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Patch for "master" branch: https:/ /reviews. mahara. org/10313