Alert message are not displaying icons

[Steven]

TITLE: Alert message are not displaying icons

BUG SUMMARY: When encountering error message ie (trying to add a folder without first entering a name) The error message is missing the Icon
==============================================

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) n/a

TEST STEPS:
------------------------
1) User log in as Site admin
2) browse to the files upload page http://mahara.stevens-lp.dynamic.wgtn.cat-it.co.nz/artefact/file/index.php
3) Click the Create new folder button (Without entering a name in the field

EXPECTED RESULT: An error message should be displayed ✔ However the error message does not display an Icon next to the text. This is needed as some people will not see colours

ACTUAL RESULT: Error message displayed but no icons associated with error

NOTE: This appears to be the same with other alert messages such as warnings, success and info

[Kristina Hoeppner (kris-hoeppner)]

Not solely relying on color is important.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10350

[Robert Lyon (robertl-9)]

We tend to add icons for things via HTML markup, like so:
 <span class="icon icon-type icon-lg" role="presentation" aria-hidden="true"></span>

But for styles that are repeated throughout the site we should try and do things in a smarter way and have the font-awesome icons be added via css

For example we add danger / success / info / warning messages, edit / delete / add buttons throughout the system and we need to add the <span> to all of them to get the icons showing in the messages.

It would be better if we just harness the :before or :after css classes to add the icons - that way if we ever need to change / adjust the icons we only need to change it in one place and styles would be more consistent.

[Kristina Hoeppner (kris-hoeppner)]

Evonne, can you please create the classes?

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10419

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10419
Committed: https://git.mahara.org/mahara/mahara/commit/cacded8474967744e0eee5e9a0197c51457247f3
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit cacded8474967744e0eee5e9a0197c51457247f3
Author: Evonne <email address hidden>
Date: Tue Oct 8 11:59:43 2019 +1300

Bug 1835329 Alert message icons

Taken out spans within alert and put in icons in alert:before,
added variation for site-messages so it can be shorter and hang
with page breakpoints. Also added icons for error messages under
form inputs.

behatnotneeded

Change-Id: Ia31af160808ecc2943bb16ba68f04e8a98c0e055

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10428

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10428
Committed: https://git.mahara.org/mahara/mahara/commit/5d483d646fb08af287e6dc911fce8f8841cfcf60
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5d483d646fb08af287e6dc911fce8f8841cfcf60
Author: Evonne <email address hidden>
Date: Wed Oct 9 11:15:55 2019 +1300

Bug 1835329 Fix upgrade alert message alignment

- put in containers in header.tpl for alert messages

behatnotneeded

Change-Id: Ie07eb2b466868ee4b81be125f6b88c05d77482cb