podman inspect doesn't scale for our needs

Bug #1833081 reported by Emilien Macchi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Emilien Macchi

Bug Description

"podman inspect" command is used by various ways in TripleO, and it seems like to be a problem at scale.
The command is reading the container database and use locks to avoid race conditions; which is problematic when running the command for multiple containers at the same time.

This bug report is a placeholder for the patches we'll send to Paunch to mitigate the situation.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to paunch (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/665731

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/666175

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on paunch (master)

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.opendev.org/665731
Reason: not in the plans for now

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (master)

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.opendev.org/666175

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to paunch (master)

Reviewed: https://review.opendev.org/665731
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=6e2ef79af303866384f8dc4de83967dbfbb704a4
Submitter: Zuul
Branch: master

commit 6e2ef79af303866384f8dc4de83967dbfbb704a4
Author: Emilien Macchi <email address hidden>
Date: Mon Jun 17 10:51:13 2019 -0400

    Reduce the usage of "podman inspect" command

    - pull_missing_images: when podman is used, do not use "inspect" but
      "podman images exists" command. We only need to know if the image
      already exists, no need to fetch all its config.

    - unique_container_name: use container_exist to find out of the
      container already exists instead of calling the "inspect" command.

    Related-Bug #1833081
    Change-Id: I1aad33bcdcede1034bc8e1267b07f84c34a09958

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to paunch (stable/stein)

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/669732

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to paunch (stable/stein)

Reviewed: https://review.opendev.org/669732
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=9cbedbfdb1c41501a7d020db1530bc87dd9264db
Submitter: Zuul
Branch: stable/stein

commit 9cbedbfdb1c41501a7d020db1530bc87dd9264db
Author: Emilien Macchi <email address hidden>
Date: Mon Jun 17 10:51:13 2019 -0400

    Reduce the usage of "podman inspect" command

    - pull_missing_images: when podman is used, do not use "inspect" but
      "podman images exists" command. We only need to know if the image
      already exists, no need to fetch all its config.

    - unique_container_name: use container_exist to find out of the
      container already exists instead of calling the "inspect" command.

    Related-Bug #1833081

    (cherry picked from commit 6e2ef79af303866384f8dc4de83967dbfbb704a4)

    Change-Id: I78fbdc17073f48790fefd35f63bc6216697f65e1

tags: added: in-stable-stein
Changed in tripleo:
milestone: train-2 → train-3
Changed in tripleo:
milestone: train-3 → ussuri-1
Changed in tripleo:
milestone: ussuri-1 → ussuri-2
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-2 → ussuri-3
Changed in tripleo:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.