[SRU] hexchat is crashing every time it is closed

[zebul666]

[ Impact ]

When using hexchat with its hexchat-python3 plugin, coupled with python 3.7, hexchat crashes while unloading the python3 plugin.

This has been reported upstream and fixed in Fedora with the same patch.

[ Test case ]

1. install hexchat hexchat-python3
2. start `hexchat` from a terminal
3. quit hexchat

The test is successful (the bug is fixed) if the process exits 0.
With this bug, the test above fails printing this in the terminal:

Fatal Python error: PyInterpreterState_Delete: remaining subinterpreters

[ Regression Potential ]

The code changes only affect the python plugin, so the core functionalities of the program will be unaffected.

Also, the patch has been in use in Fedora for months, with no known regressions, as well as being ACKed by the upstream maintainer.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Paul White (paulw2u)]

Fedora 29 had a similar problem - now fixed.

Bug report for reference:
https://bugzilla.redhat.com/show_bug.cgi?id=1632039

[Mattia Rizzolo (mapreri)]

Assuming it's the same problem, it's reported upstream as https://github.com/hexchat/hexchat/issues/2237

The patch that was uploaded in fedora is available in https://src.fedoraproject.org/rpms/hexchat/c/8a08a0c8a8da503b18f2fbb15194c5f3728a689a?branch=master

I'll take care of doing the updates as soon as I have the time to reproduce it (in debian is not happening…)

[Mattia Rizzolo (mapreri)]

actually, this was also reported in debian, but back then I didn't really investigate and then forgot…

that said, it does not happen to me...

[Launchpad Janitor (janitor)]

This bug was fixed in the package hexchat - 2.14.2-4

---------------
hexchat (2.14.2-4) unstable; urgency=medium

  * Add a patch to fix a probable crash while unloading the Python plugin
    when using Python 3.7. LP: #1830246; Closes: #921208

 -- Mattia Rizzolo <email address hidden> Sat, 25 May 2019 11:48:26 +0200

[Brian Murray (brian-murray)]

Hello zebul666, or anyone else affected,

Accepted hexchat into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/hexchat/2.14.2-4~ubuntu19.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Graham Inggs (ginggs)]

I tested 2.14.2-4~ubuntu19.04.1 in Disco.

[Brian Murray (brian-murray)]

This looks like the following error bucket and the version in -proposed doesn't appear in it.

https://errors.ubuntu.com/problem/24d8d665e8b301554c9bb5720df6d262eeb4ddf7

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for hexchat has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package hexchat - 2.14.2-4~ubuntu19.04.1

---------------
hexchat (2.14.2-4~ubuntu19.04.1) disco; urgency=medium

  * Backport crash fix to disco.

hexchat (2.14.2-4) unstable; urgency=medium

  * Add a patch to fix a probable crash while unloading the Python plugin
    when using Python 3.7. LP: #1830246; Closes: #921208

 -- Mattia Rizzolo <email address hidden> Sun, 26 May 2019 19:16:26 +0200