bug when select input , upstream fixed

[ZhiFeng Hu]

[Impact]

The current 1.11.0 has a problem when user want to type =,- or [,] symbols.
The bug prevents user to type these symbols after any chinese words type and selected.
So it make ibus-libpinyin not usable.

A proposed upload which fixes the issue is available in this PPA:

https://launchpad.net/~gunnarhj/+archive/ubuntu/ibus-libpinyin

[Test Case]

1. enable "Show suggestions" in the "Preference" dialog
2. input some Chinese text and commit, like "nihao"
3. press "." and be surprised by something quite different than the
   expected dot
4. install ibus-libpinyin from disco-proposed
5. log out and log in again
6. repeat 2.
7. press "." and find that a proper dot is typed

[Regression Potential]

It's a small change based on an upstream commit. Low regression risk.

[Original description]

for upstream bug tracker, the problem was fixed in 1.11.1
please upgrade sync upstream fixes. thanks
https://github.com/libpinyin/ibus-libpinyin/issues/175

the upstream release was:
https://github.com/libpinyin/ibus-libpinyin/releases/tag/1.11.1

[Gunnar Hjalmarsson (gunnarhj)]

Thanks for your report. ibus-libpinyin 1.11.1 will probably be synced from Debian and available in Ubuntu 19.10 without us needing to take action.

For possible backports to stable releases, can you please explain in English the nature of the problem and let us know how important it is.

[ZhiFeng Hu (hufeng1987)]

The current 1.11.0 has a problem when user want to type =,- or [,] symbols.
The bug prevent user to type these symbols after any chinese words type and selected.
So it make ibus-libpinyin not usable.
The only fix was to upgrade to 1.11.1, which the origin author fixed the problem.

so , please upgrade it to latest upstream, or the ibus-libpinyin was broken.

[Gunnar Hjalmarsson (gunnarhj)]

A proposed fix is available in this PPA:

https://launchpad.net/~gunnarhj/+archive/ubuntu/ibus-libpinyin

It would be great if you could install from there and confirm that it fixes it.

Also, TBH I wasn't able to reproduce the problem. Can you please provide a step by step case so someone (like me) who don't speak Chinese can observe the difference.

[ZhiFeng Hu (hufeng1987)]

It fix my problem. thanks.
the step to reproduce was like this.
1. add ibus-libpinyin as a input method
2. open a text editor
3. choose the ibus-libpinyin as input method
4. type some chinese words.
5. press + or - to select next page , previous page
6. select the right words, pop them to text editor
7. press + or - to try type these symbols(+, -)
8. you can not type them, because the ibus-libpinyin not allow that

[ZhiFeng Hu (hufeng1987)]

The magic code

[Gunnar Hjalmarsson (gunnarhj)]

I'm lost at item 5-8. But never mind, I trust you about it. :) Thanks!

On 2019-05-22 14:37, ZhiFeng Hu wrote:
> The magic code

Yeah, that's the code I patched in version 1.11.0-1ubuntu0.19.04~ppa instead of upgrading to 1.11.1 completely.

[Sebastien Bacher (seb128)]

Sponsored to eoan and disco

[Sebastien Bacher (seb128)]

The steps are not so clear, doing this, under GNOME (normal Ubuntu session)
- install ibus-libpinying and language-pack-gnome-zh-hans
- go to control center -> region and configure "chinese (inteliggent pinyin)"
- open gedit
- select chinese in the indicator
- type "one"
-> some chinese words are suggested
- press + (is that step needed)
-> the selector page change
- press "down" to select the second 'word'

-> try to press + or ',' and nothing happens ... would you expect for the UI to close at this point? Or do you use space to close it and then the char?
Also if '+' is supposed to go to the next page why would you like it to close the popover?

Oh, and the ppa build doesn't seem to change the behaviour for those cases...

[Launchpad Janitor (janitor)]

This bug was fixed in the package ibus-libpinyin - 1.11.0-1ubuntu1

---------------
ibus-libpinyin (1.11.0-1ubuntu1) eoan; urgency=medium

  * debian/patches/fix-SuggestionEditor.patch:
    - Upstream commit to fix bug which prevented typing of certain
      punctuation marks (LP: #1829947).

 -- Gunnar Hjalmarsson <email address hidden> Wed, 22 May 2019 13:10:00 +0200

[ZhiFeng Hu (hufeng1987)]

When it will be released to public users?
I am running ubuntu 19.04 , still not got the latest fix release.

[Gunnar Hjalmarsson (gunnarhj)]

It will take a couple of weeks. First a member of the SRU team will accept it to be built in disco-proposed, and then we need to test and confirm again. Since both Sebastien and I have difficulties to really understand how it makes a difference, I hope you can assist in the process by installing from disco-proposed and verify (again) that it solves the issue.

[Sebastien Bacher (seb128)]

@ZhiFang, could you see comment #8 and help providing a test plan than can be used? It's likely the SRU team will not accept the fix until that's not documented (the description is incomplete still)

[ZhiFeng Hu (hufeng1987)]

I am not professional developer, it's hard for me to provided test plan, can you please contact origin author, ask the upstream author provided the test plan? he will be more professional.

[Peng Wu (alexepico)]

Here are the steps to reproduce it:

1. enable "Show suggestions" in the "Preference" dialog
2. input some Chinese text and commit, like "nihao" or "dajia"
3. press "-", "+", "," or ".".

[Gunnar Hjalmarsson (gunnarhj)]

Excellent, thanks Peng Wu! That helped me write a proper test case.

[Brian Murray (brian-murray)]

Hello ZhiFeng, or anyone else affected,

Accepted ibus-libpinyin into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ibus-libpinyin/1.11.0-1ubuntu0.19.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Gunnar Hjalmarsson (gunnarhj)]

Verified the test case using ibus-libpinyin 1.11.0-1ubuntu0.19.04 from disco-proposed.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ibus-libpinyin - 1.11.0-1ubuntu0.19.04

---------------
ibus-libpinyin (1.11.0-1ubuntu0.19.04) disco; urgency=medium

  * debian/patches/fix-SuggestionEditor.patch:
    - Upstream commit to fix bug which prevented typing of certain
      punctuation marks (LP: #1829947).

 -- Gunnar Hjalmarsson <email address hidden> Wed, 22 May 2019 13:18:00 +0200

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for ibus-libpinyin has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[ZhiFeng Hu (hufeng1987)]

use it for days, no bug anymore.