Please sponsor sysinfo 0.7ubuntu3 (universe) into Hardy

[Pedro Fragoso]

Binary package hint: sysinfo

sysinfo (0.7-0ubuntu3) hardy; urgency=low

  * debian/watch: Added watch file
  * debian/control:
    - Bump Standards-Version to 3.7.3
    - b-d on debhelper (>= 5) and cdbs
    - Added Homepage
  * debian/patches/01_fix_desktop: to follow Debian sub-menu policy
  * Fix minor lintian warnings (distclean)

 -- Pedro Fragoso <email address hidden> Sun, 13 Jan 2008 20:27:43 +0000

[Luke Yelavich (themuso)]

Using cdbs for the simple-patchsys code is pointless, when the rules file is not based around cdbs. I suggest investigating another patch system like quilt or dpatch, as these systems are designed to be used in rules files that do not make use of cdbs.

Please investigate, re-upload the debdiff, and re-subscribe ubuntu-univrese-sponsors when done.

[Pedro Fragoso (ember)]

Dropped cdbs

[Luke Yelavich (themuso)]

Since you are patching the desktop file, I suggest you ensure that the desktop file validates with the desktop-file-validate tool, found in the desktop-file-utils package. This is the error I get when attempting to validate the desktop file.

sysinfo.desktop: error: value "computer.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path

You can look at the below URL for the specification referred to above for more information.

http://standards.freedesktop.org/desktop-entry-spec/latest/

Secondly, you should also include the bug number for this bug in the changelog entry, so that when your package gets uploaded, the bug is closed. The syntax is as follows: LP: #nnnnnn. In this case, it would be LP: #182700

Thirdly, while the code you added to debian/rules does work for applying patches, making use of a patch system like dpatch or quilt, saves a lot of work when it comes to adding, or removing patch support to a package that doesn't already use something like cdbs. Its fine for now, but I would encourage the research of the dpatch and quilt packages, which provide patch systems for building packages.

Please re-subscribe ubuntu-universe-sponsors once the above issues have been addressed.

[Luke Yelavich (themuso)]

Uploaded, thanks for your work.

[Launchpad Janitor (janitor)]

This bug was fixed in the package sysinfo - 0.7-0ubuntu3

---------------
sysinfo (0.7-0ubuntu3) hardy; urgency=low

  * debian/watch: Added watch file (LP: #182700)
  * debian/control:
    - Bump Standards-Version to 3.7.3
    - b-d on debhelper (>= 5) and dpatch
  * debian/patches/01_fix_desktop: to fix desktop file
  * Fix minor lintian warnings (distclean)

 -- Pedro Fragoso <email address hidden> Sun, 13 Jan 2008 20:27:43 +0000