ethmonitor does not list interfaces without assigned IP address
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
resource-agents (Debian) |
Fix Released
|
Unknown
|
|||
resource-agents (Ubuntu) |
Fix Released
|
Medium
|
Heitor Alves de Siqueira | ||
Xenial |
Fix Released
|
Medium
|
Heitor Alves de Siqueira | ||
Bionic |
Fix Released
|
Medium
|
Heitor Alves de Siqueira | ||
Cosmic |
Fix Released
|
Medium
|
Heitor Alves de Siqueira | ||
Disco |
Fix Released
|
Medium
|
Heitor Alves de Siqueira | ||
Eoan |
Fix Released
|
Medium
|
Heitor Alves de Siqueira |
Bug Description
[Impact]
Some network interfaces will not be monitored by ethmonitor
[Description]
The is_interface() function in ethmonitor tries to match an interface to a list obtained from the 'ip' tool. It lists interfaces using the 'inet' family, which omits interfaces that don't have an IP address assigned.
If the interface that we're looking for is e.g. a VLAN bridge that does not have an IP address, it won't show up in the listing and is_interface() will return false. ethmonitor will miss that interface, and it won't be available for monitoring.
Upstream commits:
- https:/
- https:/
[Test Case]
1) Ensure there's a network interface without an assigned IP address. For example, virbr0-nic will be created automatically by uvt-kvm:
# ip addr show dev virbr0-nic
11: virbr0-nic: <NO-CARRIER,
link/ether 52:54:00:e9:5e:af brd ff:ff:ff:ff:ff:ff
2) Install pcs+arping and create a new ethmonitor resource with the target interface:
# sudo apt update && sudo apt install pcs arping -y
# pcs resource create p_nic ocf:heartbeat:
3) Debug-start ethmonitor resource and check for "Interface does not exist messages"
# pcs resource debug-start p_nic
Operation start for p_nic (ocf:heartbeat:
> stderr: WARNING: Interface virbr0-nic does not exist
> stderr: NOTICE: link_status: DOWN
[Regression Potential]
The regression potential is low, since we are relaxing the monitoring conditions for interfaces without an assigned IP address. The patches have been tested against Travis-CI before being merged upstream, and will be tested against autopkgtest for each target distro.
Changed in resource-agents (Ubuntu Xenial): | |
status: | New → Confirmed |
Changed in resource-agents (Ubuntu Bionic): | |
status: | New → Confirmed |
Changed in resource-agents (Ubuntu Cosmic): | |
status: | New → Confirmed |
Changed in resource-agents (Ubuntu Xenial): | |
importance: | Undecided → Medium |
Changed in resource-agents (Ubuntu Bionic): | |
importance: | Undecided → Medium |
Changed in resource-agents (Ubuntu Cosmic): | |
importance: | Undecided → Medium |
Changed in resource-agents (Ubuntu Xenial): | |
assignee: | nobody → Heitor Alves de Siqueira (halves) |
Changed in resource-agents (Ubuntu Cosmic): | |
assignee: | nobody → Heitor Alves de Siqueira (halves) |
Changed in resource-agents (Ubuntu Bionic): | |
assignee: | nobody → Heitor Alves de Siqueira (halves) |
Changed in resource-agents (Debian): | |
status: | Unknown → New |
tags: | added: sts-sponsor |
Changed in resource-agents (Ubuntu Eoan): | |
status: | Confirmed → In Progress |
Changed in resource-agents (Ubuntu Disco): | |
status: | Confirmed → In Progress |
Changed in resource-agents (Ubuntu Cosmic): | |
status: | Confirmed → In Progress |
Changed in resource-agents (Ubuntu Bionic): | |
status: | Confirmed → In Progress |
Changed in resource-agents (Ubuntu Xenial): | |
status: | Confirmed → In Progress |
tags: | added: sts-sponsor-ddstreet |
tags: | removed: sts-sponsor sts-sponsor-ddstreet |
Changed in resource-agents (Debian): | |
status: | New → Fix Released |
Sponsored for 'eoan' considering that the:
1) Both upstream fixes are merged upstream
2) Bug is reported in debian against resource-agents (debbugs #927311)
3) Eoan is now open (#ubuntu-release topic: ... Archive: Open | Eoan Release Coordination...)
Nitpick:
d/changelog was mentionning 'unstable' instead of 'eoan'.
- Eric