Add domId attributes to Angular Comboboxes
Bug #1824709 reported by
Jane Sandberg
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned | ||
3.8 |
Fix Released
|
Medium
|
Unassigned |
Bug Description
For accessibility, we need to be able to label any combobox inputs in the angular client. To do this, we should have an id attribute that we can reference from a <label> tag (especially in the fmeditor).
Other angular components -- say the dateselect component -- have a domId input. This would probably be a good way to add an id attribute to the combobox component too.
Changed in evergreen: | |
status: | New → Confirmed |
Changed in evergreen: | |
importance: | Undecided → Medium |
milestone: | none → 3.6.1 |
Changed in evergreen: | |
milestone: | 3.6.1 → 3.6.2 |
Changed in evergreen: | |
milestone: | 3.6.2 → 3.6.3 |
Changed in evergreen: | |
milestone: | 3.6.3 → 3.6.4 |
Changed in evergreen: | |
milestone: | 3.6.4 → 3.7.2 |
Changed in evergreen: | |
milestone: | 3.7.2 → 3.7.3 |
Changed in evergreen: | |
assignee: | nobody → Jane Sandberg (sandbergja) |
no longer affects: | evergreen/3.6 |
Changed in evergreen: | |
milestone: | 3.7.3 → none |
no longer affects: | evergreen/3.9 |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Here is a pull request branch that implements the domId input for <eg-combobox>. I also added some label/domId pairs (just some low-hanging fruit, should not be considered comprehensive): user/sandbergja /lp1824709_ combobox_ id
Here is a link: https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ sandbergja/ lp1824709_ combobox_ id
Here are some testing notes from the commit message (WAVE is what I had on my computer, but aXe is another browser extension that should also do the trick):
1) Download the Wave accessibility checker.
2) Go to one of the following screens:
- Admin > Local > Course Reserves > Choose a course > Associate
item from catalog
- Admin > Local > Course Reserves > Choose a course > Associate
brief record
- MARC Batch Import
- MARC Batch Import/Export > Inspect Queue
- Staff Catalog Add to bucket
- Staff catalog conjoined items
- Hold cancel dialog
3) Right click and select "WAVE this page"
4) On the Details tab of WAVE, notice that there are several "Missing
form label" errors.
5) Apply this patch.
6) Run WAVE again; notice that the number of missing form label errors
has decreased.