Correct placement of "Accept" and "Deny" buttons for group invitations

[Kristina Hoeppner]

Issue after upgrading to Bootstrap 4.

When you are invited to join a group, the "Accept" and "Deny" buttons are not correctly placed on Main menu -> Engage -> Groups (see attachment).

To replicate:

1. Create 2 users.
2. Set up a group as user A.
3. Invite user B.
4. Log in as user B.
5. Go to Main menu -> Engage -> Groups (/group/index.html).

Expected result: You see the "Accept" and "Deny" buttons at the top of the box for the group for which the invitation is like shown in https://manual.mahara.org/en/18.10/_images/group_my_groups.png

Actual result: The buttons are floating as per the screenshot.

[Kristina Hoeppner (kris-hoeppner)]

The placement needs to be checked in every theme.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9774

[Steven (stevens-q)]

Accept and decline button display error - buttons are floated too far to the left but are within the row block - text under buttons seem to be too long before it breaks to the next line

[Steven (stevens-q)]

Commit hash: 3309cf656af78da0ab53c44f23fac2a149e94f64
Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) Mahara users exist (User1, User2, User3, User4 and User5)
2) Mahara User1 is owner and admin of Group (Group One)

TEST STEPS:
------------------------
1) Log in as Mahara User1
2) Create a Group as follows
 a) Open = Yes
 b) Friend invitations = Yes
 c) Create and edit = All group members
 d) Publicly viewable group = Yes
3) Invite User2 by following method:
      a) Browse to members page
      b) Follow the link "send multiple invitations at once." (found in text just below search field)
      c) add members from the potental members list
or
      a) Browse to the peoples page
      b) Find desired group member and click the "Edit group membership" link
      c) A modal should appear over the page titled "Edit membership for Dan User4"
      d) Check the checkbox
      e) click the "Apply" button

NOTE: bug found using this method - modal does not look right and does not close after submit

4) Log out and Log in as User2 (or as any user that has an invite to the group)
5) On the users dashboard you should see group invititation next to the user profile image icon
6) click the group invitation link
7) Verify that the Accept and decline buttons are displayed to the right side of the row block ✘

NOTE: should look like as shown in https://manual.mahara.org/en/18.10/_images/group_my_groups.png

Catalyst QA Failed Testing ✘

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9774
Committed: https://git.mahara.org/mahara/mahara/commit/0dff1c5b2a883df3e956b4d56f81789ec3921431
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0dff1c5b2a883df3e956b4d56f81789ec3921431
Author: Doris Tam <email address hidden>
Date: Mon Apr 15 17:56:49 2019 +1200

Bug 1824608: Removed extra margin conditions from 'Default Theme' scss

- causing the 'Accept/Decline' button sit 13px higher than the correct position
- font size difference changed in another bug

behatnotneeded

Change-Id: I8cd2b1043750901dcde60b20ee5ff24d707a146c

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9810

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9810
Committed: https://git.mahara.org/mahara/mahara/commit/e977694bebcb1d5e3abf2d250c902c324c3af7ee
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit e977694bebcb1d5e3abf2d250c902c324c3af7ee
Author: Doris Tam <email address hidden>
Date: Mon Apr 15 17:56:49 2019 +1200

Bug 1824608: Removed extra margin conditions from 'Default Theme' scss

- causing the 'Accept/Decline' button sit 13px higher than the correct position
- font size difference changed in another bug

behatnotneeded

Change-Id: I8cd2b1043750901dcde60b20ee5ff24d707a146c
(cherry picked from commit 0dff1c5b2a883df3e956b4d56f81789ec3921431)