Mahara

Plan block layout is broken on edit screen

Bug #1823253 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Evonne Cheung
Mahara 19.04.0

Bug Description

The plan block is not rendering like it used to on the edit screen

See attached screen shot - done in Firefox on Modern theme

Revision history for this message
Robert Lyon (robertl-9) wrote :
Changed in mahara:
status: New → Confirmed
importance: Undecided → High
milestone: none → 19.04.0
assignee: nobody → Evonne Cheung (evonne)
Evonne Cheung (evonne)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9709

Revision history for this message
Evonne Cheung (evonne) wrote :

Found that the class .pull-right no longer existed in raw, hence no style is applied to make it float right. Replaced all occurances of .pull-right to .float-right.

https://reviews.mahara.org/#/c/9709/

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Steven (stevens-q) wrote :
Revision history for this message
Steven (stevens-q) wrote :

Commit: a081099b291fd700e60626d58741a329c18f8e51
Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) Mahara User exists (no roles)

TEST STEPS:
------------------------
1) Log in as Mahara user
2) create or edit a portfolio page
3) add a plan block to the page
4) verify that the icons are to the right of the text and NOT above the text ✔

Catalyst QA Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9709
Committed: https://git.mahara.org/mahara/mahara/commit/a081099b291fd700e60626d58741a329c18f8e51
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a081099b291fd700e60626d58741a329c18f8e51
Author: Evonne Cheung <email address hidden>
Date: Fri Apr 5 10:09:17 2019 +1300

Bug #1823253 Plan block layout is broken on edit screen

Found the class .pull-right no longer existed in raw, so changed
all .pull-right to .float-right

behatnotneeded

Change-Id: I3411004af8632c7d9d557ea8feef20652d706af7

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9716

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9716
Committed: https://git.mahara.org/mahara/mahara/commit/d341a65e052b46ea55c9bb1b9d7bc2ea0d076cc6
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit d341a65e052b46ea55c9bb1b9d7bc2ea0d076cc6
Author: Evonne Cheung <email address hidden>
Date: Fri Apr 5 10:09:17 2019 +1300

Bug #1823253 Plan block layout is broken on edit screen

Found the class .pull-right no longer existed in raw, so changed
all .pull-right to .float-right

behatnotneeded

Change-Id: I3411004af8632c7d9d557ea8feef20652d706af7
(cherry picked from commit a081099b291fd700e60626d58741a329c18f8e51)

Rebecca Blundell (rjb-dev)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.