Web client has no way to recalculate patron penalties

[Blake GH]

EG 3.1.10 and likely all versions of Evergreen where the web client is primary.

XUL client had a button called "Refresh" which would trigger a patron penalty calculation. As far as I know, there isn't a way to cause the web client to perform that action.

Related IRC

http://irc.evergreen-ils.org/evergreen/2019-04-04#i_401330

[Christine Burns (christine-burns)]

This is still an issue in EG 3.7

Ideally, when the penalty threshold changes there could be a way for the system to search for existing bills that meet or exceed the threshold and apply blocking messages to user accounts or conversely to remove blocking messages on patron accounts that do not meet the threshold.

If that isn't possible, then a Refresh button that would re-calculate the penalty thresholds and apply/ remove blocking messages for an individual patron account would also be great.

[Michele Morgan (mmorgan)]

Changing importance to High on this as it allows circulation transactions to proceed that should be blocked.

We have recently configured new patron blocks and have run across this issue.

Various processes in Evergreen will calculate penalties. Some examples are circulation transactions and fine generation. But retrieving a patron in the client or opac does not calculate penalties. This leads to the situation where a patron is allowed to perform a transaction that should be blocked. It also causes confusion for staff as one transaction is allowed, but subsequent transactions are blocked.

To reproduce this on a Concerto system:

Check out the following 2 items to patron 99999376864:

CONC40000628
CONC50000720

- In Items Out, select CONC50000720, and under Actions, choose Mark Lost
- Edit the stock penalty threshold for PATRON_EXCEEDS_LOST_COUNT, changing the stock threshold to 1
- Retrieve the patron and note there is no block even after refreshing.
- In Items Out, select CONC40000628, and under Actions, choose Renew
- Note that the renewal proceeds normally, but the patron now has the 'Patron exceeds max lost item threshold' block
- Select the other item and attempt to renew.

Note that the block now appropriately prevents renewal.

[Michele Morgan (mmorgan)]

Also adding links to related bugs:

bug 1944986
bug 1890822

[Bill Erickson (berick)]

Here's a patch that updates patron penalties and reloads the page:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1823225-patron-penalty-refresh

The new menu entry is under the "Other" menu labeled "Refresh Penalties"

[John Amundson (jamundson)]

Works for me! Thanks, Bill.

I have tested this code and consent to signing off on it with my name, John Amundson, and my email address, <email address hidden>.

[Michele Morgan (mmorgan)]

Pushed to master, rel_3_9 and rel_3_8.

Thanks Bill and John!

This restores missing functionality from the xul client. There was some discussion on IRC about the possibility of penalties being recalculated automatically on patron load or with a page refresh, rather than requiring the staff user to click an option. I'll open a new bug to continue that discussion.

[Michele Morgan (mmorgan)]

As promised, bug 1983621