NUMA stress test fails, requires upstream fix stress-numa: fix calculation of max nodes

Bug #1823208 reported by Colin Ian King
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Stress-ng
Fix Released
Medium
Colin Ian King
stress-ng (Ubuntu)
Fix Released
Undecided
Unassigned
Bionic
Fix Released
Undecided
Unassigned
Cosmic
Fix Released
Undecided
Unassigned

Bug Description

SRU Cosmic, Bionic

[Justification]

The stress-ng numa stress fails because of a miscalculation of the maximum number of NUMA nodes.

Previously we were getting an upper bound to the number of max nodes instead of the actual number.

That made migrate_pages() fail in some devices due to having bits in the masks set beyond the maximum node identifier.

[Fix]

he fix is to the count of bits in "Mems_allowed" to calculate the maximum number of NUMA nodes. Upstream fix already in -proposed for Disco.

Fix is https://kernel.ubuntu.com/git/cking/stress-ng.git/commit/?id=2d4859745fd35f82081ddf8087350f85f2964971

This won't be fixed for Xenial as it has a much older mechanism for checking NUMA nodes and backporting all the changes to apply this fix is too risky for a SRU.

[Regression Potential]
This could break the NUMA stress-ng stressor node checking if this fix is incorrect; however it currently is broken so the change won't make the situation any worse than it is now.

Changed in stress-ng:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Colin Ian King (colin-king)
description: updated
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Colin, or anyone else affected,

Accepted stress-ng into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/stress-ng/0.09.42-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-cosmic
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

this is now in proposed

Changed in stress-ng (Ubuntu):
status: New → Fix Committed
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

fixed in disco

Changed in stress-ng (Ubuntu):
status: Fix Committed → Fix Released
Changed in stress-ng (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed-bionic
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Colin, or anyone else affected,

Accepted stress-ng into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/stress-ng/0.09.25-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in stress-ng (Ubuntu Cosmic):
status: New → Fix Committed
Revision history for this message
Colin Ian King (colin-king) wrote :

Verified on cosmic amd64 0.09.25-1ubuntu2

tags: added: verifica
Revision history for this message
Colin Ian King (colin-king) wrote :

Previous comment should have been:

Verified on Cosmic amd64, stress-ng 0.09.42-1ubuntu2

Also:

Verified on Bionic amd64, stress-ng 0.09.25-1ubuntu2

tags: added: verification-done verification-done-bionic verification-done-cosmic
removed: verifica verification-needed verification-needed-bionic verification-needed-cosmic
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for stress-ng has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package stress-ng - 0.09.42-1ubuntu2

---------------
stress-ng (0.09.42-1ubuntu2) cosmic; urgency=medium

  [Alfonso Sanchez-Beato]
  * stress-numa: fix calculation of max nodes (LP: #1823208)
    - use the count of bits in "Mems_allowed" to calculate the
      maximum number of NUMA nodes

 -- Colin King <email address hidden> Thu, 4 Apr 2019 17:47:11 +0100

Changed in stress-ng (Ubuntu Cosmic):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package stress-ng - 0.09.25-1ubuntu2

---------------
stress-ng (0.09.25-1ubuntu2) bionic; urgency=medium

  [Alfonso Sanchez-Beato]
  * stress-numa: fix calculation of max nodes (LP: #1823208)
    - use the count of bits in "Mems_allowed" to calculate the
      maximum number of NUMA nodes
  [Colin Ian King]
  * stress-af-alg: check for EBUSY bind failures (LP: #1815123)
    - backport of upstream prerequisits and the fix:
      13c4c58d0150 expand error message to capture more information
      39184c74f1e0 forgot to add in \n
      aed180cb7b2f make ENOKEY a non-critical failure
      7f1a617adcd6 skip over ciphers that may not exist
      88cbe87a3cc1 fix errno = ENOENT assignment, should be == comparison
      3ec28f2f5438 return EXIT_NOT_IMPLEMENTED if protocol is not supported
      a5c2cb02e8ed stress-af-alg: check for EBUSY bind failures

 -- Colin King <email address hidden> Thu, 4 Apr 2019 17:47:11 +0100

Changed in stress-ng (Ubuntu Bionic):
status: Fix Committed → Fix Released
Changed in stress-ng:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.