Image gallery functionality broken

[Steven]

BUG SUMMARY: When I add an Image gallery block and try to add pages by "Choose individual images to display" or by Display images from external gallery, The ability to select an image is gone(no my files or site files tabs or upload section with choose file button. ✘
Adding a gallery from folder functionality is working ✔

==============================================

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) User has some image files
2) User has some image files in a folder

TEST STEPS:
------------------------
1) Log in as a Mahara user (no roles)
2) create a portfolio page and add an image gallery block
3) Inside the modal fly-out - select "Choose individual images to display" or "Display images from external gallery" radio button

Expected Result: User should see My files & Site files tabs and should see a section where the user can choose a file to upload a locally stored file

Actual Result: User is unable to select any images for the gallery. User does not see My files & Site files tabs and should see a section where the user can choose a file to upload a locally stored file

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9706

[Steven (stevens-q)]

Bug Fixed -

Using the above Test Script - User can now select images for an imagegallery by any of the 3 methods
1) Display all images from a folder including images uploaded later
2) Choose individual images to display
3) Display images from external gallery" radio button

All Are working as expected ✔

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9706
Committed: https://git.mahara.org/mahara/mahara/commit/3f708bb988d4e7eb2377fa4eae8e75237a8e692c
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 3f708bb988d4e7eb2377fa4eae8e75237a8e692c
Author: Robert Lyon <email address hidden>
Date: Thu Apr 4 16:48:49 2019 +1300

Bug 1823108: Use correct 'd-none' hidden class for gallery config form

There was a clash between old 'hidden' and new 'd-none' classes

behatnotneeded

Change-Id: Ibd9ca36428afd7df4435e26b30aec1a76f2b4e8a
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9715

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9715
Committed: https://git.mahara.org/mahara/mahara/commit/fa4dcd6717d9268846a7e2dd3da8c8ed30a3a00f
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit fa4dcd6717d9268846a7e2dd3da8c8ed30a3a00f
Author: Robert Lyon <email address hidden>
Date: Thu Apr 4 16:48:49 2019 +1300

Bug 1823108: Use correct 'd-none' hidden class for gallery config form

There was a clash between old 'hidden' and new 'd-none' classes

behatnotneeded

Change-Id: Ibd9ca36428afd7df4435e26b30aec1a76f2b4e8a
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 3f708bb988d4e7eb2377fa4eae8e75237a8e692c)