Bug in vm-mime-display-internal-lynx-text/html

[Uday Reddy]

vm-mime-display-internal-lynx-text/html has a missing closing parenthesis for concat.

[Uday Reddy (reddyuday)]

Fix committed (Missing closing parenthesis for concat). Revision 1533.

[Jeff K (kosowsky)]

As I mentioned in my follow-up note, I think you still need to pass 'nil t' to the containing function 'shell-command-on-region'.
The 't' says that 'shell-command-on-region' should replace the
existing text (which is necessary).
The required correction is just to move 'nil t' outside of the concat parentheses...

At least in my case, that was required to make it work...

[Uday Reddy (reddyuday)]

Yes, noted.

[Jeff K (kosowsky)]

Thanks!
Uday Reddy wrote at about 11:50:47 -0000 on Thursday, April 4, 2019:
 > Yes, noted.
 >
 > ** Description changed:
 >
 > - In the following function in the last line, 'nil t' cannot be arguments to 'concat'
 > - This is a residue from an earlier version when there was no concat.
 > - Solution is to delete 'nil t'
 > -
 > -
 > - (defun vm-mime-display-internal-lynx-text/html (start end layout)
 > - (shell-command-on-region
 > - start (1- end)
 > - ;; (concat vm-lynx-program " -force_html /dev/stdin" )
 > - (concat vm-lynx-program " -force_html -dump -pseudo_inlines -stdin"
 > - nil t)))
 > + vm-mime-display-internal-lynx-text/html has a missing closing
 > + parenthesis for concat.
 >
 > ** Tags added: mime
 >
 > --
 > You received this bug notification because you are subscribed to the bug
 > report.
 > https://bugs.launchpad.net/bugs/1822588
 >
 > Title:
 > Bug in vm-mime-display-internal-lynx-text/html
 >
 > Status in VM:
 > Fix Committed
 >
 > Bug description:
 > vm-mime-display-internal-lynx-text/html has a missing closing
 > parenthesis for concat.
 >
 > To manage notifications about this bug go to:
 > https://bugs.launchpad.net/vm/+bug/1822588/+subscriptions